Refactor the git clone to make the variable scope smaller #5190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the authArgs into the singleflight closure, as they are only used within it. Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5190 +/- ##
==========================================
- Coverage 22.95% 22.93% -0.02%
==========================================
Files 419 419
Lines 44996 44996
==========================================
- Hits 10329 10322 -7
- Misses 33872 33878 +6
- Partials 795 796 +1 ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
Move the authArgs into the singleflight closure, as they are only used within it. Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
ffjlabo
added a commit
that referenced
this pull request
Sep 5, 2024
* Modified to use Git with PAT (#4571) * fix to read PAT settings from file Signed-off-by: sZma5a <sZma5a@geekers.io> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * piped Signed-off-by: sZma5a <sZma5a@geekers.io> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * include PAT information in URL Signed-off-by: sZma5a <sZma5a@geekers.io> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: modification of conditional branching Co-authored-by: sivchari <shibuuuu5@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: corrected error in error message Co-authored-by: sivchari <shibuuuu5@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: integration of mask function Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: make validation test Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: function name Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: rename function for validation PAT Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: fix test code as pointed out in the review Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * feat: add explan for git personal access token in document Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: change required in documentation Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: change return value Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: add test case Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: fix test Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: PipedGit struct to use password authentication instead of personal access token Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix to read PAT settings from file Signed-off-by: sZma5a <sZma5a@geekers.io> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * piped Signed-off-by: sZma5a <sZma5a@geekers.io> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: integration of mask function Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: make validation test Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: function name Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: rename function for validation PAT Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: fix test Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: PipedGit struct to use password authentication instead of personal access token Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Fix Git authentication configuration Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Update password authentication configuration Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Fix error variable name Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Fix rename password Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Refactor includePasswordAuthRemote function Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Update password authentication in clone test Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: delete PasswordAuth Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: remove unused PasswordAuth field and refactor password authentication in git client Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Remove unnecessary print statement in Validate function Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: fix code for rebase Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: remove unused GitPasswordAuth configuration Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * feat: add password decoding for password in includePasswordRemote function Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: refactor Git password authentication method Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: update password encoding in TestCloneUsingPassword Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Update docs/content/en/docs-dev/user-guide/managing-piped/configuration-reference.md Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Update pkg/config/piped.go Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * [wip] delete password Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * [wip] not tested - change token to args from url Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Fix commented out test case Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Refactor authentication in git client Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * feat: add password decoding function and replace Password string Signed-off-by: sZma5a <masaaki.haribote@gmail.com> --------- Signed-off-by: sZma5a <sZma5a@geekers.io> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Co-authored-by: sZma5a <sZma5a@geekers.io> Co-authored-by: sivchari <shibuuuu5@gmail.com> Co-authored-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Co-authored-by: Your Name <you@example.com> Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Use singleflight to clone/update repository cache (#5171) Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Refactor the git clone (#5190) Move the authArgs into the singleflight closure, as they are only used within it. Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> --------- Signed-off-by: sZma5a <sZma5a@geekers.io> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Co-authored-by: sZma5a <35451404+sZma5a@users.noreply.github.com> Co-authored-by: sZma5a <sZma5a@geekers.io> Co-authored-by: sivchari <shibuuuu5@gmail.com> Co-authored-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Co-authored-by: Your Name <you@example.com> Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com> Co-authored-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Move the authArgs into the singleflight closure, as they are only used within it.
Which issue(s) this PR fixes:
Follows #5171
Does this PR introduce a user-facing change?: