-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #4571 #5171 #5190 #5191
Cherry-pick #4571 #5171 #5190 #5191
Conversation
* fix to read PAT settings from file Signed-off-by: sZma5a <sZma5a@geekers.io> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * piped Signed-off-by: sZma5a <sZma5a@geekers.io> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * include PAT information in URL Signed-off-by: sZma5a <sZma5a@geekers.io> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: modification of conditional branching Co-authored-by: sivchari <shibuuuu5@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: corrected error in error message Co-authored-by: sivchari <shibuuuu5@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: integration of mask function Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: make validation test Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: function name Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: rename function for validation PAT Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: fix test code as pointed out in the review Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * feat: add explan for git personal access token in document Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: change required in documentation Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: change return value Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: add test case Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: fix test Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: PipedGit struct to use password authentication instead of personal access token Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix to read PAT settings from file Signed-off-by: sZma5a <sZma5a@geekers.io> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * piped Signed-off-by: sZma5a <sZma5a@geekers.io> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: integration of mask function Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: make validation test Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: function name Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: rename function for validation PAT Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: fix test Signed-off-by: swallow <masaaki@haribote-lab.net> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: PipedGit struct to use password authentication instead of personal access token Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Fix Git authentication configuration Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Update password authentication configuration Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Fix error variable name Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Fix rename password Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Refactor includePasswordAuthRemote function Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Update password authentication in clone test Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: delete PasswordAuth Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: remove unused PasswordAuth field and refactor password authentication in git client Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Remove unnecessary print statement in Validate function Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: fix code for rebase Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: remove unused GitPasswordAuth configuration Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * feat: add password decoding for password in includePasswordRemote function Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: refactor Git password authentication method Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * fix: update password encoding in TestCloneUsingPassword Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Update docs/content/en/docs-dev/user-guide/managing-piped/configuration-reference.md Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Update pkg/config/piped.go Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * [wip] delete password Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * [wip] not tested - change token to args from url Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Fix commented out test case Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * Refactor authentication in git client Signed-off-by: sZma5a <masaaki.haribote@gmail.com> * feat: add password decoding function and replace Password string Signed-off-by: sZma5a <masaaki.haribote@gmail.com> --------- Signed-off-by: sZma5a <sZma5a@geekers.io> Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Signed-off-by: Your Name <you@example.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com> Signed-off-by: swallow <masaaki@haribote-lab.net> Co-authored-by: sZma5a <sZma5a@geekers.io> Co-authored-by: sivchari <shibuuuu5@gmail.com> Co-authored-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp> Co-authored-by: Your Name <you@example.com> Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
Move the authArgs into the singleflight closure, as they are only used within it. Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-v0.48.x #5191 +/- ##
===================================================
+ Coverage 22.55% 22.57% +0.01%
===================================================
Files 519 519
Lines 57006 57067 +61
===================================================
+ Hits 12859 12882 +23
- Misses 43117 43152 +35
- Partials 1030 1033 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What this PR does / why we need it:
Cherry pick of #4571 #5171 #5190.