Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct container name in release process #17

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

tico24
Copy link
Collaborator

@tico24 tico24 commented Mar 23, 2023

This typo blocks the release.

image

image

@tico24 tico24 enabled auto-merge (squash) March 23, 2023 08:10
@tico24 tico24 requested a review from rohankmr414 March 23, 2023 08:10
@tico24 tico24 removed the request for review from rohankmr414 March 23, 2023 08:12
Signed-off-by: Tim Collins <tim@thecollins.team>
@tico24 tico24 merged commit 327313b into master Mar 23, 2023
@tico24 tico24 deleted the fix-release branch March 23, 2023 08:42
JPZ13 pushed a commit that referenced this pull request Jul 10, 2023
Drop ARM builds to save time

rm cosign and docs builds

Update paths for release manifest generation

ci and release notes paths

chore: point manifests at pipekitdev images

chore: fix checkout step

Explore gh actions

up another level

pwd

Tweak CI

try setting SRC to old argoproj value

add some debug steps

more debug

try removing this strange step

try absolute path

no touch

maybe this?

chore: Fix codegen for fork (#9)

This PR:
- Fixes the codegen panic. It wants the packages to be called argoproj
instead of pipekit. We'd have to scrub all instances of argoproj, which
we don't want to do

---------

Signed-off-by: J.P. Zivalich <jp@pipekit.io>

chore: codegen should run after unit tests pass (#11)

Fix a debug step that was put in when fixing codegen that wasn't then
reverted.

build: Fix argoexec image (#13)

This PR:
- Fixes a mismatch of argoproj/argoexec and changes it to
pipekitdev/argoexec

---------

Signed-off-by: J.P. Zivalich <jp@pipekit.io>

chore: Don't build windows images. Build ARM for local dev (#15)

- Removes the build of windows containers.
- Re-adds the build of ARM containers to ease local devtest.

Fixes #14

chore: correct container name in release process (#17)

This typo blocks the release.

![image](https://user-images.githubusercontent.com/45351296/227135267-53633f52-4633-4da1-8ba3-e96fd719b944.png)

![image](https://user-images.githubusercontent.com/45351296/227135322-de9558a9-7867-48ef-a3ec-27ca0779103e.png)

chore: Undo bad merge conflict resolutions

Signed-off-by: J.P. Zivalich <jp@pipekit.io>

fix: update for pr comments

Signed-off-by: J.P. Zivalich <jp@pipekit.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants