chore: Fix codegen for fork #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tico24
approved these changes
Mar 16, 2023
|
This is turning out to be a nasty mess to fix given all the dependencies in codegen |
isubasinghe
approved these changes
Mar 16, 2023
|
If you revert that, we can't release. |
Signed-off-by: J.P. Zivalich <jp@pipekit.io>
JPZ13
force-pushed
the
switch-codegen-makefile-to-fork
branch
from
927cd22
to
1ab3047
Compare
Signed-off-by: J.P. Zivalich <jp@pipekit.io>
|
Spoke with @tico24 today and we worked through the codegen issues |
JPZ13
added a commit
that referenced
this pull request
Jul 5, 2023
This PR: - Fixes the codegen panic. It wants the packages to be called argoproj instead of pipekit. We'd have to scrub all instances of argoproj, which we don't want to do --------- Signed-off-by: J.P. Zivalich <jp@pipekit.io>
JPZ13
pushed a commit
that referenced
this pull request
Jul 10, 2023
Drop ARM builds to save time rm cosign and docs builds Update paths for release manifest generation ci and release notes paths chore: point manifests at pipekitdev images chore: fix checkout step Explore gh actions up another level pwd Tweak CI try setting SRC to old argoproj value add some debug steps more debug try removing this strange step try absolute path no touch maybe this? chore: Fix codegen for fork (#9) This PR: - Fixes the codegen panic. It wants the packages to be called argoproj instead of pipekit. We'd have to scrub all instances of argoproj, which we don't want to do --------- Signed-off-by: J.P. Zivalich <jp@pipekit.io> chore: codegen should run after unit tests pass (#11) Fix a debug step that was put in when fixing codegen that wasn't then reverted. build: Fix argoexec image (#13) This PR: - Fixes a mismatch of argoproj/argoexec and changes it to pipekitdev/argoexec --------- Signed-off-by: J.P. Zivalich <jp@pipekit.io> chore: Don't build windows images. Build ARM for local dev (#15) - Removes the build of windows containers. - Re-adds the build of ARM containers to ease local devtest. Fixes #14 chore: correct container name in release process (#17) This typo blocks the release.   chore: Undo bad merge conflict resolutions Signed-off-by: J.P. Zivalich <jp@pipekit.io> fix: update for pr comments Signed-off-by: J.P. Zivalich <jp@pipekit.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: