Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#6057 Refactor submission files #6292

Merged
merged 17 commits into from
Nov 13, 2020
Merged

pkp/pkp-lib#6057 Refactor submission files #6292

merged 17 commits into from
Nov 13, 2020

Conversation

NateWr
Copy link
Contributor

@NateWr NateWr commented Oct 19, 2020

  • Refactor how submission files are stored

    • New PKPFileService that uses Flysystem 1.x
    • Replace FileId/Revision with revision tracking in separate table
    • Remove file system data such as mimetype from database
    • Change to filenames stored on system

  • Change downloaded filenames to use name property and
    anonymise filenames for anonymous reviews.

  • Add SubmissionFile schema and service class

  • Add API endpoints for submission files

  • Replace file upload during submission with new Vue.js component

  • Move locale property from Publication to Submission

  • Change language for file genre settings

  • Change submission file grids to use new SubmissionFileService

  • Remove ArtworkFile and SupplementaryFile classes

  • Add cli tool to get constant from its value

  • Submission files under production stage are returning error for no privileges granted  #5134 Clear assoc assignments when file is promoted

  • Prevent unwanted access to submission files #6257 Update submission file policies

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@NateWr NateWr mentioned this pull request Oct 19, 2020
Closed
@NateWr NateWr force-pushed the i6057_submission_uploads branch 2 times, most recently from dc72542 to 93f6725 Compare November 4, 2020 14:46
@NateWr NateWr mentioned this pull request Nov 10, 2020
Closed
@NateWr
pkp#6057 Refactor submission files
5f383f8 
- Refactor how submission files are stored
  - New PKPFileService that uses Flysystem 1.x
  - Replace FileId/Revision with revision tracking in separate table
  - Remove file system data such as mimetype from database
  - Change to filenames stored on system
- Change downloaded filenames to use name property and
  anonymise filenames for anonymous reviews.
- Add SubmissionFile schema and service class
- Add API endpoints for submission files
- Replace file upload during submission with new Vue.js component
- Move locale property from Publication to Submission
- Change language for file genre settings
- Change submission file grids to use new SubmissionFileService
- Remove ArtworkFile and SupplementaryFile classes
- Add cli tool to get constant from its value

- pkp#5134 Clear assoc assignments when file is promoted
- pkp#6257 Update submission file policies
@NateWr
pkp#6057 Fix OMP compatibility in submission file refactor
8d03181 
- Fix invalid database value for empty published date
- Fix author access to internal revision files
- Fix submission file grids to support internal review files
- Fix submission file metadata tab
- Fix remaining references to old submission file table column names
- Fix missing locale key when logged in as
- Fix embedded CSS files in HTML galleys
- Fix tests to support multiple submission files and genres
- Move app-specific migration code to apps
@NateWr
pkp#6057 Address code review for submission files
74b21f6 
- Update DataObject::setAllData() to not use a reference
- Use setAllData() when creating new objects in the API
- Get submission file locale in fetch query instead of
	separate query
- Use flysystem stream when downloading files
- Don't allow a submission file's createdAt property to
  be edited
- Restore deprecated log constants to preserve historical
  data
- Add missing locale keys
- Add references to several hooks
- Update license to GNU GPL v3 where it was still v2.
@NateWr
pkp#6057 Identify id column for postgres compatibility
5c98ac5
@NateWr
pkp#6057 Fix import/export tests and remove debug code
543260f
@NateWr
pkp#6057 Make submission API authorization checks extensible in apps
c750506
@NateWr
pkp#6057 Fix submission upload tests for OPS
391d855
@NateWr
pkp#6057 Fix dependent file import and common PHP notice
996151f
@NateWr
pkp#6057 Fix DataObjectTest after use of reference removed
7be90dc
@NateWr
pkp#6057 Remove proprty types unsupported before PHP 7.4
762e7f4
@NateWr
pkp#6057 Fix uncaught JS error to resolve Crossref test
2512498
@NateWr
pkp#6057 Load submission file locale when getting one file
c44f406
@NateWr
pkp#6057 Fixes to address code review
5e113b9 
- Use error logs during migrations
- Use Flysystem's copy method instead of writeStream for simplicity
- Don't prefix public method with _
@NateWr
pkp#6057 Revert changes to FileService::add so that source directory …
0404a15 
…can be outside of files_dir
@NateWr
pkp#6057 Fix submission file migrations for postgres
c26da9d
@NateWr
pkp#6057 Restore dropped sequence during migration
fbfd970
@NateWr
pkp#6057 Postgres migration should support all postgres versions
7d181bb
@NateWr NateWr merged commit 079e8ca into pkp:master Nov 13, 2020
ppv1979 added a commit to ppv1979/pkp-lib that referenced this pull request Nov 14, 2020
@ppv1979
Update ru_RU locale after PR pkp#6292
89e0f94
asmecher added a commit that referenced this pull request Nov 17, 2020
@asmecher
Merge pull request #6334 from ppv1979/master
f32145b 
Update ru_RU locale after PRs #6314, #6327, #6292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmecher asmecher asmecher left review comments

@ctgraham ctgraham ctgraham left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NateWr @CLAassistant @asmecher @ctgraham