Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#6057 Refactor submission files #6292

Merged
merged 17 commits into from
Nov 13, 2020
Merged

pkp/pkp-lib#6057 Refactor submission files #6292

merged 17 commits into from
Nov 13, 2020

Commits on Nov 12, 2020

  1. pkp#6057 Refactor submission files 

    - Refactor how submission files are stored
  - New PKPFileService that uses Flysystem 1.x
  - Replace FileId/Revision with revision tracking in separate table
  - Remove file system data such as mimetype from database
  - Change to filenames stored on system
- Change downloaded filenames to use name property and
  anonymise filenames for anonymous reviews.
- Add SubmissionFile schema and service class
- Add API endpoints for submission files
- Replace file upload during submission with new Vue.js component
- Move locale property from Publication to Submission
- Change language for file genre settings
- Change submission file grids to use new SubmissionFileService
- Remove ArtworkFile and SupplementaryFile classes
- Add cli tool to get constant from its value

- pkp#5134 Clear assoc assignments when file is promoted
- pkp#6257 Update submission file policies
    @NateWr
    NateWr committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    5f383f8 View commit details
    Browse the repository at this point in the history

  2. pkp#6057 Fix OMP compatibility in submission file refactor 

    - Fix invalid database value for empty published date
- Fix author access to internal revision files
- Fix submission file grids to support internal review files
- Fix submission file metadata tab
- Fix remaining references to old submission file table column names
- Fix missing locale key when logged in as
- Fix embedded CSS files in HTML galleys
- Fix tests to support multiple submission files and genres
- Move app-specific migration code to apps
    @NateWr
    NateWr committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    8d03181 View commit details
    Browse the repository at this point in the history

  3. pkp#6057 Address code review for submission files 

    - Update DataObject::setAllData() to not use a reference
- Use setAllData() when creating new objects in the API
- Get submission file locale in fetch query instead of
	separate query
- Use flysystem stream when downloading files
- Don't allow a submission file's createdAt property to
  be edited
- Restore deprecated log constants to preserve historical
  data
- Add missing locale keys
- Add references to several hooks
- Update license to GNU GPL v3 where it was still v2.
    @NateWr
    NateWr committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    74b21f6 View commit details
    Browse the repository at this point in the history

  4. pkp#6057 Identify id column for postgres compatibility

    @NateWr
    NateWr committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    5c98ac5 View commit details
    Browse the repository at this point in the history

  5. pkp#6057 Fix import/export tests and remove debug code

    @NateWr
    NateWr committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    543260f View commit details
    Browse the repository at this point in the history

  6. pkp#6057 Make submission API authorization checks extensible in apps

    @NateWr
    NateWr committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    c750506 View commit details
    Browse the repository at this point in the history

  7. pkp#6057 Fix submission upload tests for OPS

    @NateWr
    NateWr committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    391d855 View commit details
    Browse the repository at this point in the history

  8. pkp#6057 Fix dependent file import and common PHP notice

    @NateWr
    NateWr committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    996151f View commit details
    Browse the repository at this point in the history

  9. pkp#6057 Fix DataObjectTest after use of reference removed

    @NateWr
    NateWr committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    7be90dc View commit details
    Browse the repository at this point in the history

  10. pkp#6057 Remove proprty types unsupported before PHP 7.4

    @NateWr
    NateWr committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    762e7f4 View commit details
    Browse the repository at this point in the history

  11. pkp#6057 Fix uncaught JS error to resolve Crossref test

    @NateWr
    NateWr committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    2512498 View commit details
    Browse the repository at this point in the history

  12. pkp#6057 Load submission file locale when getting one file

    @NateWr
    NateWr committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    c44f406 View commit details
    Browse the repository at this point in the history

  13. pkp#6057 Fixes to address code review 

    - Use error logs during migrations
- Use Flysystem's copy method instead of writeStream for simplicity
- Don't prefix public method with _
    @NateWr
    NateWr committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    5e113b9 View commit details
    Browse the repository at this point in the history

  14. pkp#6057 Revert changes to FileService::add so that source directory … 

    …can be outside of files_dir
    @NateWr
    NateWr committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    0404a15 View commit details
    Browse the repository at this point in the history

  15. pkp#6057 Fix submission file migrations for postgres

    @NateWr
    NateWr committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    c26da9d View commit details
    Browse the repository at this point in the history

  16. pkp#6057 Restore dropped sequence during migration

    @NateWr
    NateWr committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    fbfd970 View commit details
    Browse the repository at this point in the history

  17. pkp#6057 Postgres migration should support all postgres versions

    @NateWr
    NateWr committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    7d181bb View commit details
    Browse the repository at this point in the history