Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/new enhancement #2079

Merged
merged 23 commits into from
Aug 22, 2023
Merged

Feature/new enhancement #2079

merged 23 commits into from
Aug 22, 2023

Commits on Aug 10, 2023

  1. Introduce exp field in Equipment model

    @U-lis
    U-lis committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    d117d81 View commit details
    Browse the repository at this point in the history

  2. Update test to validate exp value

    @U-lis
    U-lis committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6a8d658 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'development' into feature/new-enhancement

    @U-lis
    U-lis authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    c146de5 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Change EquipmentExpKey to avoid duplication

    @U-lis
    U-lis committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    5eed253 View commit details
    Browse the repository at this point in the history

  2. Change exp data type to long to avoid build error at BigInteger field

    @U-lis
    U-lis committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    fcc3197 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Backup old version

    @U-lis
    U-lis committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    bfb3356 View commit details
    Browse the repository at this point in the history

  2. Specify Action version

    @U-lis
    U-lis committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    14cb51e View commit details
    Browse the repository at this point in the history

  3. Introduce SetLevel function to set to required level at once

    @U-lis
    U-lis committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    ee662c5 View commit details
    Browse the repository at this point in the history

  4. Introduce IItemEnhancementV4 

    - This interface gets multilpe ItemIds as enhancement material.
- This is used from ItemEnhancement12 action.
    @U-lis
    U-lis committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    1a7d676 View commit details
    Browse the repository at this point in the history

  5. Update related actions to apply old action name

    @U-lis
    U-lis committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    4c691bc View commit details
    Browse the repository at this point in the history

  6. Introduce EquipmentItemUpgradePoint CSV and sheet model 

    - NOTE: Uploaded CSV file is draft version. The contents can be changed.
- New model for Equipment upgrade exp point sheet.
    @U-lis
    U-lis committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    3089664 View commit details
    Browse the repository at this point in the history

  7. Update data structure of CSVs 

    - Delete `EquipmentItemUpgradePointSheet` and integrate to
  `EnhancementCostSheet`
- Update `EnhancementCostSheet` to V3.
    - Remove unused columns.
    - Add `exp` column for required exp to reach level.
- Update `EquipmentItemSheet`
    - Add `exp` column for initial exp of new equipment.
    @U-lis
    U-lis committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    a06c4c3 View commit details
    Browse the repository at this point in the history

  8. Apply new data model 

    - Create `UpdateOptionsV3` function
    - This function uses `EnhancementCostSheetV3`.
    - This function does not check `GreatSuccess` due to deletion.
    @U-lis
    U-lis committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    d03f078 View commit details
    Browse the repository at this point in the history

  9. Update backed-up test

    @U-lis
    U-lis committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    ebb57f5 View commit details
    Browse the repository at this point in the history

  10. Introduce ItemEnhancement12 action 

    - Enhancement result is fixed to `Success`.
- Gets multiple materials regardless of grade and level.
- Uses exp of `Equipment` model and use `SetLevel` function to manage level.
- Update claculation logic of NCG cost and required block index.
    @U-lis
    U-lis committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    326c0fa View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Update ItemEnhancement action 

    - Write tests (Failing)
- Change level checking logic
- Change SetLevel params
    @U-lis
    U-lis committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    9423eba View commit details
    Browse the repository at this point in the history

  2. Merge branch 'development' into feature/new-enhancement

    @U-lis
    U-lis authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    a33beb2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/new-enhancement' of github.com:U-lis/lib9c into… 

    … feature/new-enhancement
    @U-lis
    U-lis committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    b5b3b50 View commit details
    Browse the repository at this point in the history

  4. Fix wrong test values

    @U-lis
    U-lis committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    3385958 View commit details
    Browse the repository at this point in the history

  5. Update ItemEnhancement action 

    - Fix typo
- Change `IEnumerable<Guid>` to `List<Guid>`
    @U-lis
    U-lis committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    926ea45 View commit details
    Browse the repository at this point in the history

  6. Specify ItemEnhancement version

    @U-lis
    U-lis committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    33d2d5c View commit details
    Browse the repository at this point in the history

  7. Fix broken ActionEvaluationTest

    @U-lis
    U-lis committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    e75ee20 View commit details
    Browse the repository at this point in the history

  8. Fix broken RapidCombination tests

    @U-lis
    U-lis committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    7610b6c View commit details
    Browse the repository at this point in the history