Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new enhancement #2079

Merged

Conversation

U-lis
Copy link
Contributor

@U-lis U-lis commented Aug 22, 2023

Create upstream test branch to make docker image

- This interface gets multilpe ItemIds as enhancement material.
- This is used from ItemEnhancement12 action.
- NOTE: Uploaded CSV file is draft version. The contents can be changed.
- New model for Equipment upgrade exp point sheet.
- Delete `EquipmentItemUpgradePointSheet` and integrate to
  `EnhancementCostSheet`
- Update `EnhancementCostSheet` to V3.
    - Remove unused columns.
    - Add `exp` column for required exp to reach level.
- Update `EquipmentItemSheet`
    - Add `exp` column for initial exp of new equipment.
- Create `UpdateOptionsV3` function
    - This function uses `EnhancementCostSheetV3`.
    - This function does not check `GreatSuccess` due to deletion.
- Enhancement result is fixed to `Success`.
- Gets multiple materials regardless of grade and level.
- Uses exp of `Equipment` model and use `SetLevel` function to manage level.
- Update claculation logic of NCG cost and required block index.
- Write tests (Failing)
- Change level checking logic
- Change SetLevel params
- Fix typo
- Change `IEnumerable<Guid>` to `List<Guid>`
@U-lis U-lis added enhancement New feature or request previewnet hardfork Pull requests including hardfork changes labels Aug 22, 2023
@U-lis U-lis requested a review from ipdae August 22, 2023 02:18
@U-lis U-lis self-assigned this Aug 22, 2023
@U-lis U-lis marked this pull request as ready for review August 22, 2023 02:18
@pull-request-quantifier-deprecated

This PR has 2065 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +1620 -445
Percentile : 100%

Total files changed: 22

Change summary by file extension:
.cs : +917 -268
.csv : +703 -177

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@U-lis U-lis merged commit 81f8981 into planetarium:feature/new-enhancement Aug 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Extra Large hardfork Pull requests including hardfork changes previewnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant