-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/new enhancement #2079
Feature/new enhancement #2079
Conversation
- This interface gets multilpe ItemIds as enhancement material. - This is used from ItemEnhancement12 action.
- NOTE: Uploaded CSV file is draft version. The contents can be changed. - New model for Equipment upgrade exp point sheet.
- Delete `EquipmentItemUpgradePointSheet` and integrate to `EnhancementCostSheet` - Update `EnhancementCostSheet` to V3. - Remove unused columns. - Add `exp` column for required exp to reach level. - Update `EquipmentItemSheet` - Add `exp` column for initial exp of new equipment.
- Create `UpdateOptionsV3` function - This function uses `EnhancementCostSheetV3`. - This function does not check `GreatSuccess` due to deletion.
- Enhancement result is fixed to `Success`. - Gets multiple materials regardless of grade and level. - Uses exp of `Equipment` model and use `SetLevel` function to manage level. - Update claculation logic of NCG cost and required block index.
- Write tests (Failing) - Change level checking logic - Change SetLevel params
… feature/new-enhancement
- Fix typo - Change `IEnumerable<Guid>` to `List<Guid>`
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Create upstream test branch to make docker image