Feature/additional pet #2871
Merged
Feature/additional pet #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
이외에 다른 작업은 하지 않아도 pet 소환 + 강화 + 장비제작 등등 전부 다 잘 작동하나요? |
U-lis
approved these changes
Oct 8, 2024
ipdae
reviewed
Oct 10, 2024
| @@ -34,125 +33,7 @@ public AdditionalOptionRateByFixedValueTest() | |||
| { | |||
| var sheets = TableSheetsImporter.ImportSheets(); | |||
| sheets[nameof(PetOptionSheet)] = @"ID,_PET NAME,PetLevel,OptionType,OptionValue | |||
| 1001,D:CC 블랙캣,1,ReduceRequiredBlock,5.5 | |||
There was a problem hiding this comment.
시트데이터가 변경될 경우에 영향을 안받도록 의도적으로 시트 데이터를 고정시켜둔것처럼 보이는데, 괜찮은 변경일까요?
There was a problem hiding this comment.
일단 펜리르를 제외하고는 사용하지 않는 데이터입니다. 굳이 시트 데이터를 왜 갖고와서 사용했는지 보니까, 펜리르의 펫 옵션인 AdditionalOptionRate~를 테스트 하려고 했는데 랜덤성이 있거나 하는거 때문인지 AdditionalOptionRateByFixedValue라는 펫 옵션 타입을 추가해서 테스트한 것으로 보였습니다. 위 상황에서 굳이 다른 데이터는 들고 있을 필요 없다고 생각해서 테스트에 사용하는 데이터 말고 제거하는 것으로 결정했습니다
ipdae
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
추가 펫이 생길걸 가정하고 데이터를 추가합니다