-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/additional pet #2871
Merged
eugene-doobu
merged 6 commits into
planetarium:development
from
eugene-doobu:feature/additional-pet
Oct 11, 2024
Merged
Feature/additional pet #2871
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
65d926c
refactor test
eugene-doobu e2bf943
add temp value
eugene-doobu 65e098b
Merge remote-tracking branch 'origin/development' into feature/additi…
eugene-doobu 24006d5
update pet data
eugene-doobu e37535c
Merge branch 'development' into feature/additional-pet
eugene-doobu d2ca99f
Merge branch 'development' into feature/additional-pet
eugene-doobu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
시트데이터가 변경될 경우에 영향을 안받도록 의도적으로 시트 데이터를 고정시켜둔것처럼 보이는데, 괜찮은 변경일까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일단 펜리르를 제외하고는 사용하지 않는 데이터입니다. 굳이 시트 데이터를 왜 갖고와서 사용했는지 보니까, 펜리르의 펫 옵션인 AdditionalOptionRate~를 테스트 하려고 했는데 랜덤성이 있거나 하는거 때문인지 AdditionalOptionRateByFixedValue라는 펫 옵션 타입을 추가해서 테스트한 것으로 보였습니다. 위 상황에서 굳이 다른 데이터는 들고 있을 필요 없다고 생각해서 테스트에 사용하는 데이터 말고 제거하는 것으로 결정했습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗