Enable null checker on exception files #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
requested review from
longfin,
limebell,
earlbread,
riemannulus and
moreal
Codecov Report
@@ Coverage Diff @@
## main #1021 +/- ##
==========================================
- Coverage 88.45% 87.37% -1.09%
==========================================
Files 331 300 -31
Lines 30203 28795 -1408
==========================================
- Hits 26717 25159 -1558
- Misses 1882 2051 +169
+ Partials 1604 1585 -19
|
longfin
previously approved these changes
Sep 27, 2020
limebell
requested changes
Sep 28, 2020
[changelog skip]
dahlia
force-pushed
the
null-checker
branch
from
c103c4b
to
c85e1eb
Compare
|
@planetarium/libplanet Added a missing reference to the PR number. Please review this again! |
riemannulus
approved these changes
Sep 28, 2020
moreal
approved these changes
Sep 28, 2020
limebell
approved these changes
Sep 28, 2020
earlbread
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable null checker on exceptions files. This contributes to #458.
Total files:
Files that enable null checker (39%):
Note that it was before (19%):