Move ReceiveMessageAsync to poller #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlbread
force-pushed
the
receive-message-poller
branch
2 times, most recently
from
e2edca2
to
2ca072f
Compare
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
==========================================
- Coverage 87.81% 87.69% -0.12%
==========================================
Files 189 189
Lines 12781 12749 -32
==========================================
- Hits 11223 11180 -43
- Misses 1308 1319 +11
Partials 250 250
|
longfin
reviewed
Jul 4, 2019
dahlia
previously approved these changes
Jul 4, 2019
earlbread
force-pushed
the
receive-message-poller
branch
3 times, most recently
from
85f64ed
to
fa1ae9b
Compare
longfin
previously approved these changes
Jul 4, 2019
Co-Authored-By: Swen Mun <longfinfunnel@gmail.com>
earlbread
force-pushed
the
receive-message-poller
branch
from
fa1ae9b
to
3520e8f
Compare
|
I rebased this because #330 has been merged. |
longfin
approved these changes
Jul 4, 2019
dahlia
approved these changes
Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #321 using
NetMQPollerto receive messages.