-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move namespace Libplanet.Tests.Stun to Libplanet.Stun.Tests #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
previously approved these changes
Jul 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add [changelog skip]
to the commit message.
moreal
force-pushed
the
move-namespace-of-crc32
branch
from
July 4, 2019 06:04
9867e5b
to
fa4be01
Compare
@dahlia I did 😁 |
dahlia
previously approved these changes
Jul 4, 2019
earlbread
previously approved these changes
Jul 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
- Coverage 87.81% 87.68% -0.13%
==========================================
Files 189 189
Lines 12781 12781
==========================================
- Hits 11223 11207 -16
- Misses 1308 1324 +16
Partials 250 250
|
/rebase |
The rebase failed:
To rebase manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/rebase move-namespace-of-crc32
# Navigate to the new directory.
cd .worktrees/rebase
# Rebase and resolve the likely conflicts.
git rebase --interactive --autosquash master
# Push the new branch state to GitHub.
git push --force
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/rebase |
Libplanet.Tests.Stun -> Libplanet.Stun.Tests
moreal
force-pushed
the
move-namespace-of-crc32
branch
from
July 4, 2019 06:49
fa4be01
to
f6a8cfe
Compare
earlbread
approved these changes
Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #315,
Libplanet.Tests.Stun
namespace was moved toLibplanet.Stun.Tests.
, but not testcode ofLibplanet.Stun.Crc32
.