Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move namespace Libplanet.Tests.Stun to Libplanet.Stun.Tests #330

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

moreal
Copy link
Contributor

@moreal moreal commented Jul 4, 2019

In #315, Libplanet.Tests.Stun namespace was moved to Libplanet.Stun.Tests., but not testcode of Libplanet.Stun.Crc32.

dahlia
dahlia previously approved these changes Jul 4, 2019
Copy link
Contributor

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add [changelog skip] to the commit message.

@moreal
Copy link
Contributor Author

moreal commented Jul 4, 2019

@dahlia I did 😁

dahlia
dahlia previously approved these changes Jul 4, 2019
earlbread
earlbread previously approved these changes Jul 4, 2019
@codecov
Copy link

codecov bot commented Jul 4, 2019

Codecov Report

Merging #330 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   87.81%   87.68%   -0.13%     
==========================================
  Files         189      189              
  Lines       12781    12781              
==========================================
- Hits        11223    11207      -16     
- Misses       1308     1324      +16     
  Partials      250      250
Impacted Files Coverage Δ
Libplanet.Stun.Tests/Stun/Crc32Test.cs 100% <ø> (ø) ⬆️
Libplanet/Net/NoSwarmContextException.cs 0% <0%> (-25%) ⬇️
Libplanet/Net/Swarm.cs 77.3% <0%> (-1.04%) ⬇️

@earlbread
Copy link
Contributor

/rebase

@autorebase
Copy link
Contributor

autorebase bot commented Jul 4, 2019

The rebase failed:

Not Found

To rebase manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/rebase move-namespace-of-crc32
# Navigate to the new directory.
cd .worktrees/rebase
# Rebase and resolve the likely conflicts.
git rebase --interactive --autosquash master
# Push the new branch state to GitHub.
git push --force
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/rebase

@earlbread
Copy link
Contributor

Rebase is needed because #329 has been merged. Could you please rebase it? @moreal

Libplanet.Tests.Stun -> Libplanet.Stun.Tests
@moreal moreal dismissed stale reviews from earlbread and dahlia via f6a8cfe July 4, 2019 06:49
@earlbread earlbread merged commit 912b002 into planetarium:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants