Delete an index, tx nonces and state references during chain swapping #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
feature/delete-namespace
branch
from
e971028
to
182a753
Compare
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
==========================================
+ Coverage 87.64% 87.75% +0.11%
==========================================
Files 189 189
Lines 12711 12768 +57
==========================================
+ Hits 11140 11205 +65
+ Misses 1320 1313 -7
+ Partials 251 250 -1
|
dahlia
reviewed
Jul 3, 2019
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
dahlia
previously approved these changes
Jul 3, 2019
earlbread
reviewed
Jul 4, 2019
Co-Authored-By: Seunghun Lee <waydi1@gmail.com>
earlbread
approved these changes
Jul 4, 2019
dahlia
approved these changes
Jul 4, 2019
limebell
pushed a commit
to limebell/libplanet
that referenced
this pull request
Jul 7, 2021
…-tool Store migration tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
BlockChain<T>to clean up data(index, tx nonces, staterefs) in the previous chain during.Swap(). (resolves #322) To accomplish, it also addsIStore.DeleteNamespace()andLiteDBStore/FileStoreimplementation.