Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show persons as "Awesome" Actor instead of box. #49

Closed
wants to merge 2 commits into from

Conversation

joodie
Copy link

@joodie joodie commented Mar 11, 2020

test
Renders Person and Person_Ext using portrait outline instead of a
rectangle. This makes human actors stand out much clearer in the
diagrams.

This uses the apparently new and undocumented "ActorStyle AWESOME"
skinparam. It will fall back to stick figures on older PlantUML
versions. I'm not sure if there's a way to make it fall back to older
behaviour (rendering rectangles).

Renders Person and Person_Ext using portrait outline instead of a
rectangle. This makes human actors stand out much clearer in the
diagrams.

This uses the apparently new and undocumented "ActorStyle AWESOME"
skinparam. It will fall back to stick figures on older PlantUML
versions. I'm not sure if there's a way to make it fall back to older
behaviour (rendering rectangles).
@adrianvlupu
Copy link
Member

This looks awesome !

@joodie
Copy link
Author

joodie commented Mar 12, 2020

@adrianvlupu thanks! If there's anything I can do to improve the quality of the code or otherwise speed up the process of accepting the PR, please let me know!

adrianvlupu added a commit to adrianvlupu/C4-PlantUML that referenced this pull request Mar 29, 2020
@mdopp
Copy link

mdopp commented Mar 31, 2020

@joodie first of all => Cool!
You removed the EOF character, this is distracting a little from the functional change.

@joodie
Copy link
Author

joodie commented Apr 1, 2020

@mdopp oops sorry about that. My Emacs settings added those newlines automatically. I removed the newlines.

@ncasaux
Copy link

ncasaux commented Apr 24, 2020

Hello,
I like the idea, however it seems to me that it prevents to put some description on the person.
I would prefer to have a "real" rectangle (like currently) with a circle on top as a head ;)

@joodie
Copy link
Author

joodie commented Apr 24, 2020

@ncasaux I would like to have something even closer to the diagrams on https://c4model.com/ but PlantUML doesn't allow for that. The Person icon I've used here was (recently) added to the built-in PlantUML graphics set and you can't really tweak it it in a diagram file.

@ncasaux
Copy link

ncasaux commented Apr 24, 2020

@joodie I agree... Unfortunatey, I don't have any suggestion to achieve this (if it's possible...)

@ncasaux
Copy link

ncasaux commented May 26, 2020

I just saw this other option to draw a proper person, which seems quite interesting:
#58

@roxspring
Copy link

I like the idea, however it seems to me that it prevents to put some description on the person.

Correct, PlantUML doesn't allow text to be placed within the actor symbol, but text can be placed below so it's still possible to have the description present.

I would prefer to have a "real" rectangle (like currently) with a circle on top as a head ;)

Sure, it'd be nice to render it just like the official C4 model but getting that out of PlantUML will be a struggle.
Personally I like this solution - but then I contributed the awesome actor symbol to PlantUML so am biased.
Ultimately I think this or #58 would be a massive improvement on the current plain rectangle.

NJ-Brad added a commit to NJ-Brad/C4-PlantUML that referenced this pull request Oct 6, 2020
@stale
Copy link

stale bot commented Nov 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 22, 2020
@Potherca Potherca mentioned this pull request Nov 22, 2020
@aheil
Copy link
Member

aheil commented Nov 29, 2020

It looks like we have a couple of issues addressing this. Actually this one seems to be one that aligned quite well with the "official" C4 notation. Also it seems to be minimal invasive in terms of the code based. I would vote to go for this solution.

@stale stale bot removed the wontfix This will not be worked on label Nov 29, 2020
@stale
Copy link

stale bot commented Jan 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 28, 2021
@Potherca Potherca added not-stale Stop issue from being marked stale by bot and removed wontfix This will not be worked on labels Feb 1, 2021
@Potherca
Copy link
Member

Potherca commented Feb 8, 2021

If we can confirm that this MR does conflict in logic with anything that has been merged up to now, I think this can be merged.

@Berkmann18
Copy link

That would make diagrams clearer.

@kirchsth
Copy link
Member

kirchsth commented Apr 5, 2021

A possible new concept could be

...
!$COLOR_A_5 = "#7f3b08"
!$COLOR_A_1 = "#fee0b6"
!$COLOR_NEUTRAL = "#f7f7f7"
UpdateSkinparamsAndLegendEntry("person", $bgColor=$COLOR_A_5, $fontColor=$COLOR_NEUTRAL, $borderColor=$COLOR_A_1, $shadowing="true")

SHOW_PERSON_AWESOM() ' internal it calls HIDE_PERSON_SPRITE and activate actor, and font color uses background color 

AddProperty("Name", "Flash")
AddProperty("Organization", "Zootopia")
AddProperty("Tool", "Internet Explorer 7.0")
Person(personAlias, "Label", "Optional Description (with default property header)")

Person(simplePerson, "Simple Person")

' and if a sprite is defined, rectangles are used like before
Person(simplePersonWithSprite, "Simple Person", $sprite="person2")
...

compare it with (uncolored) https://github.com/plantuml-stdlib/C4-PlantUML#element-properties

kirchsth added a commit to kirchsth/C4-PlantUML that referenced this pull request Apr 8, 2021
…nIconic and tags (7 - update sample with scaled sprites)

plantuml-stdlib#49,  plantuml-stdlib#139: Persons can be displayed as portraits - SHOW_PERSON_PORTRAIT()
@kirchsth
Copy link
Member

kirchsth commented Apr 8, 2021

I would replaced this PR with PR #141 that we can support all existing $tag, property, ... features too

@Potherca
Copy link
Member

@joodie I hope you do not mind, but I think we might want to close this MR in favor of the implementation in #141...

@Potherca Potherca added duplicate This issue or pull request already exists and removed not-stale Stop issue from being marked stale by bot labels May 2, 2021
@Potherca
Copy link
Member

Potherca commented May 2, 2021

Closing in favour of #141

@Potherca Potherca closed this May 2, 2021
Potherca added a commit that referenced this pull request Jul 4, 2021
#49, #139: Persons can be displayed as portraits - SHOW_PERSON_PORTRAIT()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

9 participants