-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show persons as "Awesome" Actor instead of box. #49
Conversation
Renders Person and Person_Ext using portrait outline instead of a rectangle. This makes human actors stand out much clearer in the diagrams. This uses the apparently new and undocumented "ActorStyle AWESOME" skinparam. It will fall back to stick figures on older PlantUML versions. I'm not sure if there's a way to make it fall back to older behaviour (rendering rectangles).
This looks awesome ! |
@adrianvlupu thanks! If there's anything I can do to improve the quality of the code or otherwise speed up the process of accepting the PR, please let me know! |
@joodie first of all => Cool! |
@mdopp oops sorry about that. My Emacs settings added those newlines automatically. I removed the newlines. |
Hello, |
@ncasaux I would like to have something even closer to the diagrams on https://c4model.com/ but PlantUML doesn't allow for that. The Person icon I've used here was (recently) added to the built-in PlantUML graphics set and you can't really tweak it it in a diagram file. |
@joodie I agree... Unfortunatey, I don't have any suggestion to achieve this (if it's possible...) |
I just saw this other option to draw a proper person, which seems quite interesting: |
Correct, PlantUML doesn't allow text to be placed within the actor symbol, but text can be placed below so it's still possible to have the description present.
Sure, it'd be nice to render it just like the official C4 model but getting that out of PlantUML will be a struggle. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
It looks like we have a couple of issues addressing this. Actually this one seems to be one that aligned quite well with the "official" C4 notation. Also it seems to be minimal invasive in terms of the code based. I would vote to go for this solution. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
If we can confirm that this MR does conflict in logic with anything that has been merged up to now, I think this can be merged. |
That would make diagrams clearer. |
A possible new concept could be
compare it with (uncolored) https://github.com/plantuml-stdlib/C4-PlantUML#element-properties |
…nIconic and tags (7 - update sample with scaled sprites) plantuml-stdlib#49, plantuml-stdlib#139: Persons can be displayed as portraits - SHOW_PERSON_PORTRAIT()
I would replaced this PR with PR #141 that we can support all existing $tag, property, ... features too |
Closing in favour of #141 |
Renders Person and Person_Ext using portrait outline instead of a
rectangle. This makes human actors stand out much clearer in the
diagrams.
This uses the apparently new and undocumented "ActorStyle AWESOME"
skinparam. It will fall back to stick figures on older PlantUML
versions. I'm not sure if there's a way to make it fall back to older
behaviour (rendering rectangles).