parse named tuples #197
Merged
parse named tuples #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
commented
Aug 22, 2024
| @@ -523,6 +523,7 @@ defmodule Ch.ConnectionTest do | |||
| }} = Ch.query(conn, "SELECT * FROM t_uuid ORDER BY y") | |||
| end | |||
|
|
|||
| @tag :skip | |||
There was a problem hiding this comment.
Latest ClickHouse now has "new JSON" https://clickhouse.com/docs/en/sql-reference/data-types/newjson, I'll add support for it later.
For now the test for "old JSON" is skipped to prevent CI errors.
ruslandoga
commented
Aug 22, 2024
lib/ch/types.ex
Outdated
|
|
||
| defp decode_identifier(<<a, rest::bytes>>, len, original, stack, acc) when is_alpha(a) do | ||
| defp decode_identifier(<<a, rest::bytes>>, len, original, stack, acc) | ||
| when is_alpha(a) or is_numeric(a) do |
There was a problem hiding this comment.
I'm assuming identifiers are alphanumeric for now. But it seems like ClickHouse allows more than that. These work:
select tuple(1 as a$, 2 as b);
select tuple(1 as a_, 2 as b);I'll try to find out what is allowed in identifiers and update it later.
|
Hm, the tests pass locally. My Right, ClickHouse now quotes the identifiers :) This is what we get: I'm dropping decoding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #196