Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with JDK 13 and 14 #1332

Merged
merged 9 commits into from
Dec 14, 2020
Merged

Conversation

tomparle
Copy link
Contributor

@tomparle tomparle commented Jun 3, 2020

Pull Request Checklist

Helpful things

Fixes

Fixes #1324

Purpose

Make Play apps runnable with JDK version up to 14.
See corresponding issue for details and migration steps for faster-gt module users.

@tomparle tomparle mentioned this pull request Jun 3, 2020
@tomparle
Copy link
Contributor Author

tomparle commented Jun 3, 2020

Sorry I used a method available only from JDK 9, which made the build fail. I'll fix this tomorrow.

@tomparle
Copy link
Contributor Author

tomparle commented Jun 8, 2020

(build fixed)

Copy link
Member

@xael-fry xael-fry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me

@xael-fry xael-fry merged commit e7d8fcb into playframework:master Dec 14, 2020
@xael-fry xael-fry added the dependencies Pull requests that update a dependency file label Dec 14, 2020
@xael-fry xael-fry added this to the 1.6.0 milestone Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JDK 13/14 support
3 participants