Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Eclipse JDT Core v3.23 to enable JDK 14 source #1338

Merged

Conversation

tazmaniax
Copy link
Collaborator

@tazmaniax tazmaniax commented Oct 25, 2020

Task-Url: tazmaniax#5

Helpful things

Fixes

Updated the Eclipse JDT Core version along with other source compile libraries.

Purpose

Allows code to compile to JDK 14 source level

Background Context

This was being held up because the "Faster Groovy Templates" had a compile issue using Eclipse JDT Core > v18 but this has now been resolved, see references below

References

@tazmaniax
Copy link
Collaborator Author

@tomparle this is an updated pull request of your pull request #1332 for issue #1324

@tazmaniax
Copy link
Collaborator Author

tazmaniax commented Nov 10, 2020

I fixed the issue with the old Groovy jars lying around but the build still seems to be broken - not sure what the issue is but I don't think it's related to the changes.

A change between Groovy 3.0.4 and 3.0.5 resulted in a change in the
compiler output message
@tazmaniax
Copy link
Collaborator Author

tazmaniax commented Nov 10, 2020

@tomparle @asolntsev @xael-fry finally a good result here! That was a bit painful.

So all good under JDK 1.8 but under JDK 15 I get a few failing tests (binding, invocationContext) and a few with errors (errors, routing), but I haven't had a chance to resolve them yet. I'm out of time on this so if anyone else can investigate that would be great! Not sure if these > JDK 1.8 issues are a blocker with accepting this pull request.
CleanShot 2020-11-10 at 12 47 44

Not strictly part of this change but while there is an opportunity :)
@tomparle
Copy link
Contributor

@tazmaniax congratulations for your work !

The changes in the Groovy Template do not seem obvious, good job for having figured this out.
It seems that all tests passed now ?

Copy link
Member

@xael-fry xael-fry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me

@xael-fry xael-fry merged commit 6d8b253 into playframework:master Dec 14, 2020
@xael-fry
Copy link
Member

merged thanks @tazmaniax

@xael-fry xael-fry mentioned this pull request Dec 14, 2020
5 tasks
@tazmaniax tazmaniax mentioned this pull request Dec 14, 2020
@tazmaniax
Copy link
Collaborator Author

tazmaniax commented Dec 14, 2020

@xael-fry I see you've merged #1325 and #1332 in commits 1056dbc and e7d8fcb respectively but in fact this pull request superseded both of those, see #1338 (comment), and the Travis build appears to be failing with those commits so you might want to revert them on master

CleanShot 2020-12-14 at 08 08 08

@tazmaniax
Copy link
Collaborator Author

tazmaniax commented Dec 14, 2020

@xael-fry ok looks like the build failure has been resolved so all good - just a bit of a messy commit history

CleanShot 2020-12-14 at 08 18 49

@xael-fry xael-fry added this to the 1.5.4 milestone Dec 14, 2020
@tazmaniax tazmaniax changed the title #5: Update to latest Eclipse JDT Core v3.23 to enable JDK 14 source Update to latest Eclipse JDT Core v3.23 to enable JDK 14 source Dec 14, 2020
@xael-fry
Copy link
Member

@tazmaniax Yes I see my mistake after, there was some conflict in merge, but I fix it.
Thanks

tazmaniax added a commit to tazmaniax/play1 that referenced this pull request Jan 26, 2022
Applies changes made in playframework#1368
to revert unnecessary and incorrect changes to GroovyTemplate introduced
in playframework#1338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants