Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cutomizecrud #5

Closed
wants to merge 17 commits into from
Closed

Conversation

opensource21
Copy link
Contributor

[#289] is the pull request ticket.

It started for [#265], but I found some errors on the way. So it's fixed [#288], [#265], [#287} [#286}.
I made a mark to the commits.
Please check it. After having some feedback I can try to create clean feature branches, add documentation and tests. Unfortunately I'm new to git and after hg and bzr I must say it's the most difficult :-/
I don't know if I will have the next days internet, so be patient if I don't answer.

I added a optimistic locking app as example how to use the new possibilities.

@guillaumebort
Copy link
Contributor

Please update the documentation pages about CRUD to explain how you can customize ObjectType. Also I don't think that a dedicated sample application is useful. Can you merge your test cases in the already existing just-test-cases application?

Thank you.

@opensource21
Copy link
Contributor Author

I have changed the visibility and added a testcase to the CRUD selenium test.
Furthermore I added documentation.
The optimistic-locking example shows how optimistic-locking can works and give a lot of examples what can done by customizing. I'm unsure where the best place is to publish that.

@guillaumebort
Copy link
Contributor

Applied, but it was a very complicated merge. Can you review it?

@opensource21
Copy link
Contributor Author

Yes of course sorry for the trouble. The implementation wasn't straight forward and git is hard to learn. I was unsure if the request will be accepted, that was the reason why I don't create a new pull request with code cleanup.

@opensource21
Copy link
Contributor Author

I finished the review. There was only one unused import. I has made a note on the line in github (this is really an impressive feature of github and much better than launchpad). I'm unsure if you read this comments. Can you give me a short note, that I know you have read it?

xael-fry pushed a commit that referenced this pull request Dec 14, 2020
…1338)

* #5: Update to latest Eclipse JDT Core v3.23 to enable JDK 14 source

Task-Url: tazmaniax#5

* #5: Updated Groovy to v3.0.6

Task-Url: tazmaniax#5

* 5: Replace LinkedList with Collection

Task-Url: tazmaniax#5

* Remove old versions of groovy

* Replace reflection based approach to adding compiler phase operation

* Fix groovy template compilation test

A change between Groovy 3.0.4 and 3.0.5 resulted in a change in the
compiler output message

* Updated a few dependencies

Not strictly part of this change but while there is an opportunity :)
tomparle pushed a commit to tomparle/play1 that referenced this pull request Mar 15, 2022
…JDK 14 source

Task-Url: tazmaniax#5

* playframework#5: Updated Groovy to v3.0.6

Task-Url: tazmaniax#5

* 5: Replace LinkedList with Collection

Task-Url: tazmaniax#5

* Remove old versions of groovy

* Replace reflection based approach to adding compiler phase operation

* Fix groovy template compilation test

A change between Groovy 3.0.4 and 3.0.5 resulted in a change in the
compiler output message

* Updated a few dependencies

Not strictly part of this change but while there is an opportunity :)
tomparle pushed a commit to tomparle/play1 that referenced this pull request Mar 29, 2022
…JDK 14 source

Task-Url: tazmaniax#5

* playframework#5: Updated Groovy to v3.0.6

Task-Url: tazmaniax#5

* 5: Replace LinkedList with Collection

Task-Url: tazmaniax#5

* Remove old versions of groovy

* Replace reflection based approach to adding compiler phase operation

* Fix groovy template compilation test

A change between Groovy 3.0.4 and 3.0.5 resulted in a change in the
compiler output message

* Updated a few dependencies

Not strictly part of this change but while there is an opportunity :)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants