show and hide actionmenu elements depending selection and copied elem…

[erral]

…ents

Fixes #961

@ionlizarazu

[mister-roboto]

@ionlizarazu you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

[mister-roboto]

@erral thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

[mister-roboto]

@erral thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

[erral]

@jenkins-plone-org please run jobs

[jensens]

I am not sure if hiding is the best solution, or if it is better to grey out/ disable the buttons.

Opinions?

[erral]

Yeah, it should be something that does not allow to make any action when clicking on them, hiding is one option.

[jensens]

@thet @agitator - any opinions on this?

[thet]

I think disabling would be less disturbing instead of hiding/showing depending on the state. It probably also makes it harder to orientate in the UI when buttons disappear on different places.
On the other side hiding cleans up the UI.
If disabling the buttons is also an option accessibility wise, then I'd go for disabling.

There are already buttons disabled (should be at least), including when pasting and nothing was selected:
Button initialization:

mockup/mockup/patterns/structure/js/views/app.js

Line 357 in 65b92f2

setupButtons: function() {

Paste button disable/undisable:

mockup/mockup/patterns/structure/js/views/app.js

Line 236 in 65b92f2

togglePasteBtn: function(){

ButtonGroup: https://github.com/plone/mockup/blob/65b92f2178df68013ccccf7bdd4354add870422d/mockup/js/ui/views/buttongroup.js
ButtonView: https://github.com/plone/mockup/blob/65b92f2178df68013ccccf7bdd4354add870422d/mockup/js/ui/views/button.js

[vincentfretin]

This was a regression. See my fixes in #996