-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CSS issue on "Pattern options" tab in Resource Registries #990
Fix CSS issue on "Pattern options" tab in Resource Registries #990
Conversation
@vincentfretin thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:
With this simple comment all the jobs will be started automatically. Happy hacking! |
5991a58
to
91da7f6
Compare
@@ -90,18 +90,13 @@ | |||
} | |||
|
|||
.lessvariables, | |||
.patternoptionsuse { | |||
.patternoptions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was clearly a typo. patternoptionsuse doesn't exist anywhere in the code.
padding-top: 10px; | ||
clear: both; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rule doesn't make any sense. We are in .pat-resourceregistry
already so the final rule is .pat-resourceregistry .pat-resourceregistry .lessvariables .form
so it's never used. The rule that is used is the one just above with padding-top 15px.
@jenkins-plone-org please run jobs |
If you want to test, make sure you have |
See plone/Products.CMFPlone#1111