Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS issue on "Pattern options" tab in Resource Registries #990

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

vincentfretin
Copy link
Member

@mister-roboto
Copy link

@vincentfretin thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@vincentfretin vincentfretin force-pushed the fix-resourceregistry-patternoptions-padding branch from 5991a58 to 91da7f6 Compare July 1, 2020 10:28
@@ -90,18 +90,13 @@
}

.lessvariables,
.patternoptionsuse {
.patternoptions {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was clearly a typo. patternoptionsuse doesn't exist anywhere in the code.

padding-top: 10px;
clear: both;
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule doesn't make any sense. We are in .pat-resourceregistry already so the final rule is .pat-resourceregistry .pat-resourceregistry .lessvariables .form so it's never used. The rule that is used is the one just above with padding-top 15px.

@vincentfretin
Copy link
Member Author

@jenkins-plone-org please run jobs

@vincentfretin
Copy link
Member Author

vincentfretin commented Jul 1, 2020

If you want to test, make sure you have mockup in auto-checkout in checkouts.cfg, did again the buildout, and restarted the instance. Now in Control Panel, Resource Registries, check "Development Mode(only logged in users)", press "Develop CSS" on "resourceregistry" bundle, click "Save. Then refresh the page (F5) and go to "Pattern Options".
The fix will be in a Plone release version when we will rebuild the bundles in plone.staticresources with latest mockup master.

@vincentfretin vincentfretin merged commit 4a8c300 into master Jul 1, 2020
@vincentfretin vincentfretin deleted the fix-resourceregistry-patternoptions-padding branch July 1, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants