Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS issue on "Pattern options" tab in Resource Registries #990

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Fix CSS issue on "Pattern options" tab in Resource Registries #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions mockup/patterns/resourceregistry/pattern.resourceregistry.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,18 +90,13 @@
}

.lessvariables,
.patternoptionsuse {
.patternoptions {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was clearly a typo. patternoptionsuse doesn't exist anywhere in the code.

.form{
padding-top: 15px;
clear: both;
}
}

.pat-resourceregistry .lessvariables .form {
padding-top: 10px;
clear: both;
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule doesn't make any sense. We are in .pat-resourceregistry already so the final rule is .pat-resourceregistry .pat-resourceregistry .lessvariables .form so it's never used. The rule that is used is the one just above with padding-top 15px.

.patternoptions {
.form-control-feedback {
top: 0;
Expand Down
3 changes: 3 additions & 0 deletions news/990.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix CSS issue on "Pattern options" tab in Resource Registries (padding-top of the tab content).
This fixes https://github.com/plone/Products.CMFPlone/issues/1111
[vincentfretin]