Fix GHA test action to just run tests on Plone 5.2. Plone 6 CI is bes… #1259
Conversation
…t done in Jenkins. Update to the tested Plone version to 5.2.6 Refs. #1255
|
@ale-rt thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@tisto I hope this PR makes my point more clear than what I wrote in #1255 (comment) Disclaimer I might have not have a full vision of the big picture but I am pretty convinced I nailed it. |
| @@ -7,7 +7,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| python-version: [3.8, 3.7, 3.6] | |||
| plone-version: ["6.0", "5.2"] | |||
There was a problem hiding this comment.
@ale-rt as outlined in my comment I'd prefer to keep things as they are in tests.yml. The rest of the PR is fine. :)
There was a problem hiding this comment.
I know what you outlined, but I do not understand it :)
jenkins tests are already doing everything is needed and testing Plone 6.0 here is just adding complications.
In addition the tested Plone 6 version is already old, see:
Line 4 in 52b2bcf
I am still convinced this PR is doing the right thing!
|
See the discussion that happened in #1255 |
…t done in Jenkins. Update to the tested Plone version to 5.2.6
Refs. #1255