Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GHA test action to just run tests on Plone 5.2. Plone 6 CI is bes… #1259

Closed
wants to merge 1 commit into from
Closed

Fix GHA test action to just run tests on Plone 5.2. Plone 6 CI is bes… #1259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Tests
name: Check Plone 5.2 compatibility, code analysis and documentation
on: [push]
jobs:
build:
Expand All @@ -7,7 +7,7 @@ jobs:
fail-fast: false
matrix:
python-version: [3.8, 3.7, 3.6]
plone-version: ["6.0", "5.2"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ale-rt as outlined in my comment I'd prefer to keep things as they are in tests.yml. The rest of the PR is fine. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know what you outlined, but I do not understand it :)
jenkins tests are already doing everything is needed and testing Plone 6.0 here is just adding complications.
In addition the tested Plone 6 version is already old, see:

I am still convinced this PR is doing the right thing!

plone-version: ["5.2"]

steps:
# git checkout
Expand Down Expand Up @@ -51,8 +51,8 @@ jobs:
- name: test
run: bin/test

# test no uncommited changes
- name: test no uncommited changes
# test no uncommitted changes
- name: test no uncommitted changes
run: bin/test-no-uncommitted-doc-changes
env:
PYTHON_VERSION: ${{ matrix.python-version }}
Expand Down
2 changes: 1 addition & 1 deletion plone-5.2.x.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[buildout]
extends =
https://dist.plone.org/release/5.2.5/versions.cfg
https://dist.plone.org/release/5.2.6/versions.cfg
base.cfg
find-links += https://dist.plone.org/thirdparty/
versions=versions
Expand Down