Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@plone/registry as ESM module, move to TS, complete documentation #6399

Merged
merged 95 commits into from
Oct 27, 2024

Conversation

sneridagh
Copy link
Member


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit f603dd2
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/671e431657d0bb0008a507a6

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes.

packages/registry/news/6399.breaking Outdated Show resolved Hide resolved
packages/scripts/news/6399.feature Outdated Show resolved Hide resolved
packages/registry/README.md Outdated Show resolved Hide resolved
packages/registry/README.md Outdated Show resolved Hide resolved
packages/registry/README.md Outdated Show resolved Hide resolved
packages/registry/README.md Outdated Show resolved Hide resolved
packages/registry/README.md Outdated Show resolved Hide resolved
docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved
docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved
docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved
sneridagh and others added 7 commits October 14, 2024 09:16
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just docs config stuff for now. I did not bother with content yet.

packages/registry/docs/_static/Plone_logo_square.png Outdated Show resolved Hide resolved
packages/registry/docs/conf.py Outdated Show resolved Hide resolved
packages/registry/docs/conf.py Outdated Show resolved Hide resolved
packages/registry/docs/conf.py Outdated Show resolved Hide resolved
packages/registry/docs/conf.py Outdated Show resolved Hide resolved
packages/registry/docs/conf.py Outdated Show resolved Hide resolved
docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved
docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved
packages/registry/.readthedocs.yaml Outdated Show resolved Hide resolved
@sneridagh
Copy link
Member Author

@stevepiercy @davisagli I think that now it's complete. Looking forward to merge it this weekend.

Next is: #6397 along with it, I would integrate this docs in the official docs too.

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went nuts with Diataxis Framework and reorganized content in Conceptual and How-to guides.

I have only one comment for your consideration, otherwise this is GTG.

packages/registry/docs/how-to-guides/shadow-a-component.md Outdated Show resolved Hide resolved
@sneridagh
Copy link
Member Author

Okay, let's do it! Merging, at last.

@sneridagh sneridagh merged commit 83e2a6a into main Oct 27, 2024
69 checks passed
@sneridagh sneridagh deleted the registryesmandts branch October 27, 2024 14:37
sneridagh added a commit that referenced this pull request Oct 28, 2024
* main:
  Release 18.0.0-alpha.47
  Release generate-volto 9.0.0-alpha.20
  Release @plone/scripts 3.7.0
  Release @plone/registry 2.0.0-alpha.0
  Improve @plone/registry release-it config
  `@plone/registry` as ESM module, move to TS, complete documentation (#6399)
sneridagh added a commit that referenced this pull request Oct 30, 2024
* main: (111 commits)
  Moved `applyBlockDefaults` one component up so the style is computed correctly (#6451)
  Fix useSelector is returned a different result when called with the s… (#6450)
  Fix page changes not being announced by assistive technology when navigating using the client-side router (#5288)
  BlockStyleWrapper aware of block themes (#6445)
  A11y: Wrap ToC Block within nav tag (#6084)
  Fix backend error when there is no query supplied (#6423)
  Added upgrade guide fix for HMR (#6446)
  Fix CSS lint in Volto Slate (#6444)
  Release 18.0.0-alpha.47
  Release generate-volto 9.0.0-alpha.20
  Release @plone/scripts 3.7.0
  Release @plone/registry 2.0.0-alpha.0
  Improve @plone/registry release-it config
  `@plone/registry` as ESM module, move to TS, complete documentation (#6399)
  [Next.js] Better Vercel deployment (#6441)
  Replace all `yarn` appearences with `pnpm` (#6433)
  Add deprecation notices to the Upgrade guide (#6426)
  Clean up #6422 (#6443)
  Rename page title from Frontend to Volto UI (#6438)
  URL-Management control panel: Add missing translations (#6436)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants