Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all yarn appearences with pnpm #6433

Merged
merged 7 commits into from
Oct 26, 2024
Merged

Conversation

sneridagh
Copy link
Member

@sneridagh sneridagh commented Oct 24, 2024


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #


📚 Documentation preview 📚: https://volto--6433.org.readthedocs.build/

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit f82f652
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/671cd574920bba000857808e

docs/source/contributing/linting.md Outdated Show resolved Hide resolved
docs/source/development/creating-project.md Outdated Show resolved Hide resolved
docs/source/development/lazyload.md Outdated Show resolved Hide resolved
Co-authored-by: David Glick <david@glicksoftware.com>
Comment on lines 110 to 111
pnpm add volto-slate
ADDONS=volto-slate:asDefault pnpm start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really still use this example? Could it be confusing for users to see a slate example now that slate is the default?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Do we have another add-on that we could use, perhaps VLT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

stevepiercy added a commit to plone/documentation that referenced this pull request Oct 26, 2024
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make the changes, then it's GTG

docs/source/contributing/linting.md Outdated Show resolved Hide resolved
docs/source/development/creating-project.md Show resolved Hide resolved
docs/source/development/creating-project.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oopsie, specify exact alpha version.

docs/source/development/creating-project.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, pending resolution of @pnicolli's comment.

@sneridagh this PR needs a change log entry.

@sneridagh
Copy link
Member Author

@stevepiercy GTG

@sneridagh sneridagh merged commit 715503d into main Oct 26, 2024
68 of 69 checks passed
@sneridagh sneridagh deleted the replaceallsimpleyarnappearences branch October 26, 2024 11:52
stevepiercy added a commit to plone/documentation that referenced this pull request Oct 26, 2024
sneridagh added a commit that referenced this pull request Oct 26, 2024
* main:
  [Next.js] Better Vercel deployment (#6441)
  Replace all `yarn` appearences with `pnpm` (#6433)
  Add deprecation notices to the Upgrade guide (#6426)
  Clean up #6422 (#6443)
sneridagh added a commit that referenced this pull request Oct 26, 2024
* main:
  [Next.js] Better Vercel deployment (#6441)
  Replace all `yarn` appearences with `pnpm` (#6433)
  Add deprecation notices to the Upgrade guide (#6426)
  Clean up #6422 (#6443)
  Rename page title from Frontend to Volto UI (#6438)
  URL-Management control panel: Add missing translations (#6436)
  Fix broken links (#6440)
  Fix broken links (#6439)
  Used resource title instead of resource type in page title. (#6402)
sneridagh added a commit that referenced this pull request Oct 30, 2024
* main: (111 commits)
  Moved `applyBlockDefaults` one component up so the style is computed correctly (#6451)
  Fix useSelector is returned a different result when called with the s… (#6450)
  Fix page changes not being announced by assistive technology when navigating using the client-side router (#5288)
  BlockStyleWrapper aware of block themes (#6445)
  A11y: Wrap ToC Block within nav tag (#6084)
  Fix backend error when there is no query supplied (#6423)
  Added upgrade guide fix for HMR (#6446)
  Fix CSS lint in Volto Slate (#6444)
  Release 18.0.0-alpha.47
  Release generate-volto 9.0.0-alpha.20
  Release @plone/scripts 3.7.0
  Release @plone/registry 2.0.0-alpha.0
  Improve @plone/registry release-it config
  `@plone/registry` as ESM module, move to TS, complete documentation (#6399)
  [Next.js] Better Vercel deployment (#6441)
  Replace all `yarn` appearences with `pnpm` (#6433)
  Add deprecation notices to the Upgrade guide (#6426)
  Clean up #6422 (#6443)
  Rename page title from Frontend to Volto UI (#6438)
  URL-Management control panel: Add missing translations (#6436)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants