Clean up build scripts and imports #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HammadTheOne
requested review from
alexcjohnson and
Marc-Andre-Rivet
as code owners
dash_bio/package-info.json
Outdated
| "build:dev": "npm run build:js-dev && npm run build:py" | ||
| "build:backends": "node ./extract-meta src/lib/components > dash_bio/metadata.json && python get_version_info.py && dash-generate-components ./src/lib/components dash_bio -p package-info.json --r-prefix='dashbio' --r-imports='dash' --r-depends='manhattanly'", | ||
| "build": "npm run build:js && npm run build:backends", | ||
| "postbuild": "es-check es5 dash_bio/*.js" | ||
| }, | ||
| "author": "The Plotly Team <dashbio@plotly.com>", | ||
| "maintainer": "Ryan Patrick Kyle <ryan@plotly.com>", |
There was a problem hiding this comment.
We should probably change this... yourself?
There was a problem hiding this comment.
Yep, changed in 4e6cf1d.
1 task
dash_bio/__init__.py
Outdated
| @@ -115,7 +110,5 @@ | |||
| _css_dist = [] | |||
There was a problem hiding this comment.
This line can be dropped as well now... not a big deal though :)
There was a problem hiding this comment.
Thanks for the catch!
🔪 in 02144f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #534
Closes #556
About
Description of changes
This PR changes
__init__.pyto use__imports__generated by the build process instead of the_dash.development.component_loader.load_componentsmethod. It also cleans up thepackage.jsonin line with what we have fordcc, with 3 standard build scripts for thejsandbackends.