Add support for Julia components to be generated #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HammadTheOne
requested review from
alexcjohnson and
Marc-Andre-Rivet
as code owners
|
Thanks @HammadTheOne - so to be clear the issue is that we were referencing a variable within propTypes, and the value needs to be inlined. Can you open an issue in dash to have the component generator throw an error when this happens? The Python and R components did generate, but were missing the values here prior to this fix, and we'd be better off pushing component authors to fix this kind of problem up front rather than expecting them to notice a problem later and fix it. Also: The Julia package is being built in a separate repo https://github.com/plotly/DashBio.jl so it seems like we shouldn't include Julia artifacts here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Description of changes
This PR fixes an incompatibility with
dash-generate-componentsand the way some of thepropTypeeswere referenced which prevented Julia versions of all components from being generated.In addition, the Julia prefix will be added to the build script as part of #563 so that all back-ends can be generated at the same time.