oracle: new connector #437

n-riesco · 2018-05-17T20:32:17Z

Implemented connector to Oracle based on node-oracledb.
Implemented a pool of clients to ensure all the request from a
connector share the same client. For more details, see
backend/persistent/datastores/pool.js.
Upgraded to electron@2.0 and node@8, so that:
- both node and electron have ABI 57 (for which node-oracledb provides
  binaries)
- unable to use electron@1.8 due to issue resulting in a empty window
  at some startups
Added Dockerfile and npm scripts to build and launch a container with
an Oracle Express database setup for testing.
Ensure connector failures are logged.
Added npm script test-unit-oracle for testing. See CONTRIBUTING.md
for the requirements to run these tests.
Updated documentation in CONTRIBUTING.md.

Closes #322

n-riesco · 2018-05-17T21:00:06Z

TODO:

fix Falcon fails to start if bad configuration files #342
hide failure to request oracledb when running in CircleCI
fix integration test (caused by SSL Handshake Error using node >= 8.6.0 nodejs/node#16196)

n-riesco · 2018-05-18T20:06:35Z

Oracle Test Database

Oracle Instant Client (all)

Oracle Instant Client (win64)
Oracle Instant Client (linux)
Oracle Instant Client Downloads for macOS (Intel x86)

shannonlal

Do you need an oracle.LICENSE file as well?

shannonlal · 2018-05-20T17:25:55Z

.travis.yml

@@ -3,7 +3,7 @@ matrix:
    - os: osx
      osx_image: xcode9.0
      language: node_js
-      node_js: "6"
+      node_js: "8"


Just to confirm. Once this is moved in we will need to use NodeJS 8? Will earlier versions work? Not an issue just want to know.

The oracle connector won't work in electron and yarn will refuse to install.

If you force yarn to ignore the node version (yarn install --ignore-engines), then Falcon seems to work (I mean everything I tried, except the Oracle connector).

shannonlal · 2018-05-20T17:31:56Z

Looks good. No major issues. Just had a couple of quick questions for you on but should not block merging this in💃

n-riesco · 2018-05-21T07:09:52Z

@shannonlal

Do you need an oracle.LICENSE file as well?

We need written permission to use Oracle's logo. For the time being, the icon for Oracle's connector is just text (similar to what I've used for DB2 and CSV).

n-riesco · 2018-05-23T15:23:07Z

I've tested this branch on windows:

the web app works (i.e. oracledb works in Node)
the desktop app doesn't (i.e. oracledb fails when required from Electron)

The issue I have with the electron app has already been reported: oracle/node-oracledb#917

Running .\node_modules\.bin\electron-rebuild.cmd --version=2.0.1 --arch=x64 --only=oracledb as suggested in oracle/node-oracledb#881 (comment) fails with NAN-related errors (like these reported in oracle/node-oracledb#862 (comment))

Potential leads:

Master contains commits to be released with v2.3 that seem to address the NAN-related errors:
- oracle/node-oracledb@13680a6
- oracle/node-oracledb@00313f8
Solution to investigate: create our own npm packages

* Implemented connector to Oracle based on node-oracledb. * Implemented a pool of clients to ensure all the request from a connector share the same client. For more details, see `backend/persistent/datastores/pool.js`. * Upgraded to electron@2.0 and node@8, so that: - both node and electron have ABI 57 (for which node-oracledb provides binaries) - unable to use electron@1.8 due to issue resulting in a empty window at some startups * Added Dockerfile and npm scripts to build and launch a container with an Oracle Express database setup for testing. * Ensure connector failures are logged. * Added npm script `test-unit-oracle` for testing. See `CONTRIBUTING.md` for the requirements to run these tests. * Updated documentation in `CONTRIBUTING.md`. Closes #322

* See nodejs/node#16196 for further details about the cause.

* Ensure error response is formatted as {error: message: 'xxxx'}.

* Fixed the code parsing a connection error message. * Ensure error message is a string. * Ensure isConnected() and isSaved() returns false when status code is 500. * Added tests. Closes #342

* Use source package from github to prevent the use of prebuilt binaries and force the rebuild of the native module.

n-riesco · 2018-05-24T20:14:04Z

3c13700 fixes the issue with the windows installer.

I've tested both, the linux and the windows installer.

@tarzzz, could you test the mac installer here, please?

To test the connector for oracle, you'll need to:

Install the free Oracle Instant Client for mac, as described here
Build the docker image with the oracle database for testing: yarn docker:oracle:build
Launch the docker image: yarn docker:oracle:start
Wait until the docker container prints out Ready
Install falcon using the installer here
Open Falcon and create an connection to oracle using the sample credentials.

tarzzz · 2018-05-25T15:05:48Z

Getting this while trying to connect:

It seems an issue with my Oracle client installation.. !!

tarzzz · 2018-05-25T15:22:55Z

Okay, I was able to make it work by correctly installing clients:

Everything looks good to me from testing point of view.. 💃

n-riesco · 2018-05-25T17:13:35Z

@tarzzz I'm planning to update README.md with the instructions for installing Oracle Install Client.
For mac, did you have to do anything else other what is described here?

n-riesco force-pushed the oracle branch from b946996 to a1fc39e Compare May 17, 2018 20:37

n-riesco force-pushed the oracle branch 2 times, most recently from ab3b642 to bf60ecc Compare May 18, 2018 18:50

shannonlal reviewed May 20, 2018

View reviewed changes

n-riesco mentioned this pull request May 23, 2018

oracledb electron crashes on execution oracle/node-oracledb#917

Closed

n-riesco added 5 commits May 24, 2018 20:22

certificates: fix handshake failure in node v8

5fb5a7e

* See nodejs/node#16196 for further details about the cause.

servers: fix '/connections/:id' error response

9b69c13

* Ensure error response is formatted as {error: message: 'xxxx'}.

ConnectButton: fix multiple bugs

a0d0840

* Fixed the code parsing a connection error message. * Ensure error message is a string. * Ensure isConnected() and isSaved() returns false when status code is 500. * Added tests. Closes #342

oracle: fix electron native module

3c13700

* Use source package from github to prevent the use of prebuilt binaries and force the rebuild of the native module.

n-riesco force-pushed the oracle branch from bf60ecc to 3c13700 Compare May 24, 2018 19:23

n-riesco merged commit 125ddb1 into master May 25, 2018

n-riesco mentioned this pull request May 25, 2018

New Database Connectors #345

Open

10 tasks

n-riesco deleted the oracle branch May 28, 2018 16:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

oracle: new connector #437

oracle: new connector #437

n-riesco commented May 17, 2018

n-riesco commented May 17, 2018 •

edited

Loading

n-riesco commented May 18, 2018 •

edited

Loading

shannonlal left a comment

shannonlal May 20, 2018

n-riesco May 21, 2018

shannonlal commented May 20, 2018

n-riesco commented May 21, 2018

n-riesco commented May 23, 2018 •

edited

Loading

n-riesco commented May 24, 2018

tarzzz commented May 25, 2018

tarzzz commented May 25, 2018

n-riesco commented May 25, 2018

oracle: new connector #437

oracle: new connector #437

Conversation

n-riesco commented May 17, 2018

n-riesco commented May 17, 2018 • edited Loading

n-riesco commented May 18, 2018 • edited Loading

shannonlal left a comment

Choose a reason for hiding this comment

shannonlal May 20, 2018

Choose a reason for hiding this comment

n-riesco May 21, 2018

Choose a reason for hiding this comment

shannonlal commented May 20, 2018

n-riesco commented May 21, 2018

n-riesco commented May 23, 2018 • edited Loading

n-riesco commented May 24, 2018

tarzzz commented May 25, 2018

tarzzz commented May 25, 2018

n-riesco commented May 25, 2018

n-riesco commented May 17, 2018 •

edited

Loading

n-riesco commented May 18, 2018 •

edited

Loading

n-riesco commented May 23, 2018 •

edited

Loading