Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninitialized string offset in "vendor/pocketmine/binaryutils/src/Binary" #2559

Closed
95CivicSi opened this issue Dec 12, 2018 · 6 comments
Closed
Labels
Category: Protocol Related to (changes in) the Minecraft network protocol Resolution: Fixed

Comments

@95CivicSi
Copy link
Contributor

Issue description

When trying to craft items, players get disconnected from the game with "Internal server error." This is accompanied by an error in the console that is similar to this:

ErrorException: "Uninitialized string offset: 1681" (EXCEPTION) in "vendor/pocketmine/binaryutils/src/Binary" at line 448
  • Expected result: What were you expecting to happen?
    Expected crafting tables and inventory craft slots to respond with matching recipes and final crafted objects.
  • Actual result: Client gets disconnected and loses whatever items are in the crafting slots.

Steps to reproduce the issue

  1. Setup and run a clean copy of PocketMine on release/3.5, commit 5946ec8
  2. Attempt to craft items on a crafting table or in your inventory (usually requires trying to place 2 items).

OS and versions

  • PocketMine-MP: 5946ec8
  • PHP: 7.2
  • Server OS: Tested on Windows 10 and Ubuntu 18.04
  • Game version: PE/Win10

Plugins

  • Test on a clean server without plugins: is the issue reproducible without any plugins loaded?
    Yes
    If the issue is not reproducible without plugins:
  • Have you asked for help on our forums before creating an issue?
  • Can you provide sample, minimal reproducing code for the issue? If so, paste it in the bottom section
  • Paste your list of plugins here (use the 'plugins' command in PocketMine-MP)

Crashdump, backtrace or other files

  • ...
@dktapps dktapps added Status: Reproduced Bug has been reproduced, but cause has not yet been identified Category: Protocol Related to (changes in) the Minecraft network protocol labels Dec 12, 2018
@dktapps dktapps closed this as completed Dec 12, 2018
@dktapps dktapps added Resolution: Fixed and removed Status: Reproduced Bug has been reproduced, but cause has not yet been identified labels Dec 12, 2018
@isoz
Copy link

isoz commented Dec 12, 2018

This is still happening to me.

@isoz
Copy link

isoz commented Dec 12, 2018

also some players are getting "logged out due to Internal server error" once the error happens.

@ilyasaftr
Copy link

This is still happening to me too.

@xinghao2003
Copy link

It also happening to me
2018-12-13 [15:40:14] [Server thread/CRITICAL]: Error: "Cannot write non-existing field "pitch"" (EXCEPTION) in "src/pocketmine/network/mcpe/protocol/DataPacket" at line 146

@dktapps
Copy link
Member

dktapps commented Dec 13, 2018

"still happening" isn't helpful. I need reproducing steps and backtraces.

@dktapps
Copy link
Member

dktapps commented Dec 13, 2018

Please open new issues for any fresh bugs you're encountering, since the one that caused this one specifically is already fixed.

@pmmp pmmp locked as resolved and limited conversation to collaborators Dec 13, 2018
dktapps added a commit that referenced this issue Dec 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Protocol Related to (changes in) the Minecraft network protocol Resolution: Fixed
Projects
None yet
Development

No branches or pull requests

5 participants