Builtin thread-local object storage for AsyncTask

[SOF3]

@dktapps deleted my original pull request. Blame him and ask him for description.

[dktapps]

#blamedktapps
Sorry this has been such a pain in the butt.

[SOF3]

Rebased commits

[SOF3]

@Aericio Please do not post comments irrelevant to this pull request here. If you continue to post improperly, you may be blocked from @pmmp.

[robske110]

Awesome :)

[robske110]

love this :P

[remotevase]

Lol hilarious

[SOF3]

@remotevase please stop spamming on our repo.

[remotevase]

Okay, but expect to see more pull requests from me that actually contribute CODE not just templates for issues and pull requests.

[SOF3]

@remotevase Please immediately stop using pull requests and issues as chatroom or forums, or respective action will be taken.

[robske110]

I could try to test this, if you want
-?

[robske110]

The commit name seems to be not very descriptive

[SOF3]

@robske110 that's all that this pull request is about. Other changes are just to assist this addition. You don't want to store a value; you just want to retrieve a value, and you do so by storing it first, along with other things like a storage to put these values at. But the main point is that you can use AsyncTask;:fetchLocal.

At least, I think it is good enough just for a commit name to identify a change. Better than this 😉

[robske110]

well, still looks weird for me, but i guess ok

[SOF3]

Tested with this script plugin:

<?php

/**
 * @name AsyncTest
 * @author SOFe
 * @main AsyncTest\AsyncTest
 * @api 2.1.0
 * @version 1.0.0
 */

namespace AsyncTest;

class AsyncTest extends \pocketmine\plugin\PluginBase {
        public function onEnable(){
                $asyncTask = new class($this) extends \pocketmine\scheduler\AsyncTask{
                        public function onRun(){
                                sleep(5);
                        }

                        public function onCompletion(\pocketmine\Server $server){
                                $server->getLogger()->info('$asyncTask');
                                var_dump(get_class($this->fetchLocal($server)));
                        }
                };
                $this->getServer()->getScheduler()->scheduleAsyncTask($asyncTask);

                $asyncTask2 = new class($this) extends \pocketmine\scheduler\AsyncTask{
                        public function onRun(){
                                sleep(10);
                        }

                        public function onCompletion(\pocketmine\Server $server){
                                $server->getLogger()->info('$asyncTask2');
                                // var_dump(get_class($this->fetchLocal($server)));
                        }
                };
                $this->getServer()->getScheduler()->scheduleAsyncTask($asyncTask2);
        }
}

Note that anonymous classes are used in this script, and the values to store for an AsyncTask is the $this in the new class($this) part.

Output with ./start.sh --debug.level=2:

[12:07:07] [Server thread/INFO]: Enabling AsyncTest v1.0.0
# Irrelevant lines skipped
[12:07:07] [Server thread/INFO]: Done (1.414s)! For help, type "help" or "?"
[12:07:12] [Server thread/INFO]: $asyncTask
~\plugins\async.php:22:
string(19) "AsyncTest\AsyncTest"
[12:07:22] [Server thread/INFO]: $asyncTask2
[12:07:22] [Server thread/DEBUG]: AsyncTask class@anonymous~\plugins\async.php0000006F77B8036A stored local complex data but did not remove them after completion

[SOF3]

Question: Should this be at the WARN level instead?

[SOF3]

The pull request is ready for merge. Apart from the question about WARN vs DEBUG above, it is OK for merging. Please review this pull request if you find no problems in the API design.

[robske110]

I think NOTICE would be the right level.

[robske110]

Looks good now, I'd say ready for merge 👍

[dktapps]

Didn't you change this?

[dktapps]

Discussed in detail.