PhpStorm automated formatting #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dktapps
approved these changes
Oct 3, 2016
SOF3
commented
Oct 3, 2016
| @@ -100,7 +100,7 @@ public function nextSignedInt(){ | |||
| $this->y = $this->z; | |||
| $this->z = $this->w; | |||
| $this->w = ($this->w ^ (($this->w >> 19) & 0x7fffffff) | |||
| ^ ($t ^ (($t >> 8) & 0x7fffffff))) & 0xffffffff; | |||
There was a problem hiding this comment.
This is necessary because tabs may have different size on different editors, and using spaces for inline indentation is more appropriate.
|
Looks fine to me. Any further changes? |
This was referenced Mar 31, 2017
Closed
Closed
This was referenced Jun 3, 2017
ghost
mentioned this pull request
ghost
mentioned this pull request
Closed
Closed
ghost
mentioned this pull request
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
dktapps
added
Category: Core
dktapps
added
Type: Enhancement
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And further reviewed by human (@SOF3)
To satisfy needs of automatic formatting, block and item ID constants of the same value are placed together using
const A = 1,B = 1;rather thanconst A = 1; const B = 1;.Needs second review by another human. (Please use GitHub PR reviews to leave comments)
This is the last in the OCD trilogy.