Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mace Implementation #6446

Closed
wants to merge 79 commits into from
Closed

Mace Implementation #6446

wants to merge 79 commits into from

Conversation

KnosTx
Copy link

@KnosTx KnosTx commented Sep 8, 2024

Introduction

Implementation for the 1.21.0 Mace

Relevant issues

N/A

Details

https://minecraft.wiki/w/Mace

Changes

Both class' for the Mace item have been created:

  • pocketmine\item\Mace.php

One class has been added to handle mace smash ground sound:

  • pocketmine/world/sound/MaceSmashGroundSound.php

And one class has been added to handle mace smash air sound:

  • pocketmine/world/sound/MaceSmashAirSound.php

The Mace has been implemented as a vanilla item.

API changes

N/A

Behavioural changes

N/A

Backwards compatibility

N/A

Follow-up

N/A

Mojang Screenshot

Noor holding a Mace

Noor using the mace against a zombie.

Video

Minecraft_2024-09-08-18-09-49.mp4

Tests

I tested this PR by doing the following (tick all that apply):

  • Writing PHPUnit tests (commit these in the tests/phpunit folder)
  • Playtesting using a Minecraft client (provide screenshots or a video)
  • Writing a test plugin (provide the code and sample output)
  • Other (provide details)

@KnosTx

This comment was marked as spam.

@KnosTx KnosTx closed this by deleting the head repository Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants