-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mace Implementation #6446
Closed
Closed
Mace Implementation #6446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mace Implementation. JavierLeon9966
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Implementation for the 1.21.0
Mace
Relevant issues
N/A
Details
https://minecraft.wiki/w/Mace
Changes
Both class' for the Mace item have been created:
One class has been added to handle mace smash ground sound:
And one class has been added to handle mace smash air sound:
The Mace has been implemented as a vanilla item.
API changes
N/A
Behavioural changes
N/A
Backwards compatibility
N/A
Follow-up
N/A
Mojang Screenshot
Noor holding a Mace
Noor using the mace against a zombie.
Video
Minecraft_2024-09-08-18-09-49.mp4
Tests
I tested this PR by doing the following (tick all that apply):
tests/phpunit
folder)