Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed kicked for flying when walking on lily pads #7

Merged
merged 1 commit into from
Oct 3, 2016
Merged

Fixed kicked for flying when walking on lily pads #7

merged 1 commit into from
Oct 3, 2016

Conversation

dktapps
Copy link
Member

@dktapps dktapps commented Oct 1, 2016 •
edited
Loading

Standing on top of a lily pad for roughly 5 seconds currently causes players to be kicked for flying.

Changes

  • Changed Flowable to return null when recalculating bounding boxes.
  • Fixed lily pad bounding box (1/64 tall, #blamemojang for making it different in PE)
  • Removed some redundant properties (already in parent class or not needed/incorrect)

Tests

Walked on top of lily pads, the bug no longer occurs. Tested with various other flowables and found no issues.

archie426
archie426 approved these changes Oct 1, 2016
View reviewed changes
Copy link

@archie426 archie426 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have had no problem with this so far.

@dktapps
Copy link
Member Author

dktapps commented Oct 1, 2016

@XFuryMCPE this is why I said #blameshoghicp :P took me ages to find this
https://github.com/pmmp/PocketMine-MP/blame/master/src/pocketmine/block/Flowable.php

@XFuryMCPE
Copy link

wow

@archie426
Copy link

@dktapps how are we supposed to add blazes as well, he might of left us a bit of help #blameshoghi

@dktapps
Copy link
Member Author

dktapps commented Oct 2, 2016

This is not a spoon discussion forum. Enough.

@archie426
Copy link

@dktapps sorry

@dktapps dktapps merged commit 2b6d058 into master Oct 3, 2016
@dktapps dktapps deleted the lily-pads branch October 3, 2016 08:17
@dktapps dktapps added Category: Gameplay Related to Minecraft gameplay experience Category: Core Related to internal functionality Type: Fix Bug fix, typo fix, or any other fix and removed Category: Core Related to internal functionality labels Oct 18, 2016
@MisteFr MisteFr mentioned this pull request Dec 8, 2016
Closed
@buchwasa buchwasa mentioned this pull request Feb 16, 2017
Closed
@kabluinc kabluinc mentioned this pull request Mar 31, 2017
Closed
@RompeCraneos RompeCraneos mentioned this pull request Mar 31, 2017
Closed
@kabluinc kabluinc mentioned this pull request Apr 1, 2017
Closed
@JunkDaCoder JunkDaCoder mentioned this pull request Apr 4, 2017
Closed
@Renual1337 Renual1337 mentioned this pull request May 7, 2017
Closed
@kabluinc kabluinc mentioned this pull request May 12, 2017
Closed
@AydarTop AydarTop mentioned this pull request Jun 2, 2017
Closed
@XDqrkneZ XDqrkneZ mentioned this pull request Jun 3, 2017
Closed
This was referenced Jun 3, 2017
Closed
Closed
@Pizzahaet Pizzahaet mentioned this pull request Jun 8, 2017
Closed
@ChaostixZix ChaostixZix mentioned this pull request Jun 10, 2017
Closed
@ghost ghost mentioned this pull request Jun 11, 2017
Closed
@XDqrkneZ XDqrkneZ mentioned this pull request Jun 12, 2017
Closed
@Natman-bad Natman-bad mentioned this pull request Aug 1, 2021
Closed
@thinh2021 thinh2021 mentioned this pull request Sep 29, 2021
Closed
@ssRelovess38 ssRelovess38 mentioned this pull request Oct 5, 2021
Closed
This was referenced Nov 3, 2021
Closed
Closed
@Levkonik Levkonik mentioned this pull request Jan 28, 2022
Closed
@Raphael716 Raphael716 mentioned this pull request Feb 8, 2022
Closed
@StefanFox-Dev StefanFox-Dev mentioned this pull request May 26, 2022
Closed
@StefanFox-Dev StefanFox-Dev mentioned this pull request Jul 5, 2022
Closed
@jasonmadmax jasonmadmax mentioned this pull request Jul 21, 2022
Closed
@PmmpDevelop PmmpDevelop mentioned this pull request Aug 9, 2022
Closed
@BeeAZ-pm-pl BeeAZ-pm-pl mentioned this pull request Aug 29, 2022
Closed
@AkuGatau19 AkuGatau19 mentioned this pull request Oct 29, 2022
Closed
@gamegam gamegam mentioned this pull request Jan 24, 2023
Closed
This was referenced Feb 13, 2023
Closed
Closed
@krake79 krake79 mentioned this pull request Apr 19, 2023
Closed
@ahnsunggwan45 ahnsunggwan45 mentioned this pull request May 30, 2023
Closed
@gggggGGGGSQ gggggGGGGSQ mentioned this pull request Jun 26, 2023
Closed
@ahnsunggwan45 ahnsunggwan45 mentioned this pull request Jun 27, 2023
Closed
@gamegam gamegam mentioned this pull request Jul 6, 2023
Closed
@GabBiswajit GabBiswajit mentioned this pull request Jul 6, 2023
Closed
@TamaoD TamaoD mentioned this pull request Jul 19, 2023
Closed
@KohakuChan-Dev KohakuChan-Dev mentioned this pull request Oct 10, 2023
Closed
@KohakuChan-Dev KohakuChan-Dev mentioned this pull request Oct 29, 2023
Closed
@jjwon419 jjwon419 mentioned this pull request Jan 12, 2024
Closed
@DragonfireHD98 DragonfireHD98 mentioned this pull request Jan 23, 2024
Closed
@svoe2 svoe2 mentioned this pull request Feb 26, 2024
Closed
@Didin109 Didin109 mentioned this pull request Aug 17, 2024
Closed
@kaio200816 kaio200816 mentioned this pull request Sep 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archie426 archie426 archie426 approved these changes

@catgirlinspace catgirlinspace catgirlinspace approved these changes

Assignees
No one assigned
Labels
Category: Gameplay Related to Minecraft gameplay experience Type: Fix Bug fix, typo fix, or any other fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dktapps @XFuryMCPE @archie426 @catgirlinspace