Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PivotControls scaling #1249

Merged
merged 10 commits into from
Mar 7, 2024

Conversation

STINGNAILS
Copy link
Contributor

@STINGNAILS STINGNAILS commented Jan 26, 2023

Why

Issue 1046

What

Added scaling spheres to the PivotControls

Checklist

  • Link codesandbox
  • Documentation updated
  • Storybook entry added
  • Ready to be merged

@vercel
Copy link

vercel bot commented Jan 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 0:12am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 26, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7ec0e2c:

Sandbox Source
awesome-tu-r33xhf Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@skypu3
Copy link

skypu3 commented May 9, 2023

does it merge into master ?

@AdamLeBlanc
Copy link

Hey, this is really useful and exactly what I need for something I am working on. Any idea when/if this will be released on the main branch?

@cyango
Copy link

cyango commented Oct 11, 2023

the scale deforms the pivot controls

image

Is this fixable?

@abhirakshit
Copy link

Hello, just checking on the eta for this feature on the main branch.
Thanks

@mjlever1991
Copy link

Hi just wondering when this is gonna be merged, thanks.

@mbxxr
Copy link

mbxxr commented Jan 24, 2024

+1

1 similar comment
@cyango
Copy link

cyango commented Jan 24, 2024

+1

@STINGNAILS
Copy link
Contributor Author

Ok, will check into the mentioned issue with deforming within a week and ask for merging it, sorry for the delay...

@mjlever1991
Copy link

Great. How do we use this? Does it need to be merged with main Drei branch or is there another way to use this?

@cyango
Copy link

cyango commented Feb 15, 2024

Great. How do we use this? Does it need to be merged with main Drei branch or is there another way to use this?

Same question :)

@mbxxr
Copy link

mbxxr commented Mar 3, 2024

Excited to push a project forward with this, any idea when we can expect it to be merged?

@drcmda drcmda merged commit 6611a7e into pmndrs:master Mar 7, 2024
4 checks passed
@drcmda
Copy link
Member

drcmda commented Mar 7, 2024

thanks @STINGNAILS !
@cyango @mjlever1991 @mbxxr

Copy link

github-actions bot commented Mar 7, 2024

🎉 This PR is included in version 9.100.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cyango
Copy link

cyango commented May 8, 2024

I tested this today with latest versions of three.js, r3f and drei. Issue still happening:
https://codesandbox.io/p/sandbox/object-gizmo-controls-forked-s5v6hd?file=%2Fsrc%2FApp.js%3A6%2C1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants