-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes aad aliases. Closes #5676 #6131
Conversation
Thank you @nanddeepn! |
hi, this PR is now targeting v9. |
hey @nanddeepn, it seems we have some conflicts after our last merges. |
249a1a0
to
a53eedc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍. Awesome work @nanddeepn 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nanddeepn what we missed in this change is
- These aliasses can be removed when we start working
that was mentioned in the related issue.
it means we should remove all deprecation warnings like
from the entra
tree and get rid of aadCommands
also this change is almost the same as #6141
Lets consolidate those two changes to a single PR that closes two issues 🙏
872d524
to
0d94b15
Compare
Removes aad aliases. Closes #5676
/cmd/aad
to/cmd/entra
in the docs.--aadGroupIds
and--aadGroupNames
options inspo group member add
.--aadGroupIds
and--aadGroupNames
options inspo group member remove
.--aadId
option inspo user ensure
.