Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes aad options. Closes #5823 #6141

Open
wants to merge 42 commits into
base: v10
Choose a base branch
from
Open

Conversation

nanddeepn
Copy link
Contributor

@nanddeepn nanddeepn commented Jul 12, 2024

Removes aad options. Closes #5823 and #5676

@nanddeepn nanddeepn changed the title Removes aad options. Closes #5745 Removes aad options. Closes #5823 Jul 12, 2024
@milanholemans
Copy link
Contributor

Thanks @nanddeepn!

@Adam-it
Copy link
Contributor

Adam-it commented Aug 3, 2024

hey @nanddeepn may I kindly ask you to rebase with latest v9 and resolve the conflicts before we proceed 👍.
Let me know if you need any kind of help.
Thank you for your constant work and contributions to the community 👏. You Rock 🤩

@Adam-it
Copy link
Contributor

Adam-it commented Aug 11, 2024

@nanddeepn this change is almost same as #6131. Lets concat those two PR's to a single change closing both issues.
Please let's leave the upgrade guidance from this PR since it is really helpful but we also need to add this new page to sidebar.ts 👍

@nanddeepn
Copy link
Contributor Author

Hi @Adam-it
Concating two PRs to close #5823 and #5676

@Adam-it
Copy link
Contributor

Adam-it commented Aug 14, 2024

Hi @Adam-it
Concating two PRs to close #5823 and #5676

Awesome 🤩😍

@Adam-it
Copy link
Contributor

Adam-it commented Aug 30, 2024

Due to an upcoming breaking change connected to CLI for Microsoft 365 login experience we will need to do a v9 release a bit sooner than we anticipated. Due to that we had to change the target of this PR to v10 which will be the next regular major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-major PR for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove aad options Remove aad aliasses in the next major version
8 participants