Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an RPC method to clear the engine signer #113

Closed
vkomenda opened this issue Mar 29, 2019 · 1 comment · Fixed by #199
Closed

Add an RPC method to clear the engine signer #113

vkomenda opened this issue Mar 29, 2019 · 1 comment · Fixed by #199
Assignees

Comments

@vkomenda
Copy link

A new RPC method parity_clearEngineSigner is required as discussed in gnosischain/posdao-test-setup#41.

@vkomenda vkomenda self-assigned this Mar 29, 2019
phahulin pushed a commit that referenced this issue Apr 2, 2019
Add RPC method parity_clearEngineSigner
Fixes #113
afck pushed a commit that referenced this issue Apr 11, 2019
Add RPC method parity_clearEngineSigner
Fixes #113
afck pushed a commit that referenced this issue Jul 24, 2019
Add RPC method parity_clearEngineSigner
Fixes #113
vkomenda added a commit that referenced this issue Jul 25, 2019
Add RPC method parity_clearEngineSigner
Fixes #113
vkomenda added a commit that referenced this issue Aug 27, 2019
Add RPC method parity_clearEngineSigner
Fixes #113
afck pushed a commit that referenced this issue Oct 1, 2019
Add RPC method parity_clearEngineSigner
Fixes #113
afck pushed a commit that referenced this issue Oct 7, 2019
Add RPC method parity_clearEngineSigner
Fixes #113
afck pushed a commit that referenced this issue Oct 8, 2019
Add RPC method parity_clearEngineSigner
Fixes #113
afck pushed a commit that referenced this issue Oct 8, 2019
Add RPC method parity_clearEngineSigner
Fixes #113
dvdplm pushed a commit to openethereum/parity-ethereum that referenced this issue Oct 9, 2019
* RPC method parity_clearEngineSigner

Add RPC method parity_clearEngineSigner
Fixes poanetwork#113

* corrected the return type of clear_author

* review comment responses and a rebase fix

* removed a spurrious warning

* moved clear_signer functionality to set_signer

* Merge clear_author into MinerService::set_author.

* Add trace logs to Clique::set_signer.

* Clique: Don't lock signer multiple times.
afck pushed a commit that referenced this issue Oct 22, 2019
Original commit messages:

RPC method parity_clearEngineSigner

Add RPC method parity_clearEngineSigner
Fixes #113

corrected the return type of clear_author

review comment responses and a rebase fix

removed a spurrious warning

moved clear_signer functionality to set_signer

Merge clear_author into MinerService::set_author.

Add trace logs to Clique::set_signer.

Clique: Don't lock signer multiple times.
varasev pushed a commit that referenced this issue Oct 23, 2019
Original commit messages:

RPC method parity_clearEngineSigner

Add RPC method parity_clearEngineSigner
Fixes #113

corrected the return type of clear_author

review comment responses and a rebase fix

removed a spurrious warning

moved clear_signer functionality to set_signer

Merge clear_author into MinerService::set_author.

Add trace logs to Clique::set_signer.

Clique: Don't lock signer multiple times.
@varasev
Copy link

varasev commented Oct 23, 2019

Improved in #199.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants