RPC method parity_clearEngineSigner #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afck
approved these changes
Apr 2, 2019
| // returns `Seal::None`. Meanwhile it looks as if the intention of the test writer was | ||
| // to receive a `Seal::Regular` here. This can be achieved similarly to how it's done in | ||
| // `generates_seal_iff_sealer_is_set()`, by stepping the engine and issuing a block in | ||
| // the new step signed by `keccak("0")`. |
There was a problem hiding this comment.
Good catch! I guess the test should say else { panic!() } or something?
phahulin
approved these changes
Apr 2, 2019
afck
pushed a commit
that referenced
this pull request
Apr 11, 2019
Add RPC method parity_clearEngineSigner Fixes #113
afck
pushed a commit
that referenced
this pull request
Jul 24, 2019
Add RPC method parity_clearEngineSigner Fixes #113
afck
pushed a commit
that referenced
this pull request
Oct 7, 2019
Add RPC method parity_clearEngineSigner Fixes #113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113.