✨ Feature: Use events from s3 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasdeleon
changed the title
nicolasdeleon
changed the title
pablojp
reviewed
May 2, 2022
| @@ -3,7 +3,7 @@ import axios from 'axios'; | |||
| class POAP { | |||
|
|
|||
| static async fetchEvents() { | |||
| const response = await axios.get('https://api.poap.xyz/events'); | |||
| const response = await axios.get('https://api-event.poap.xyz'); | |||
There was a problem hiding this comment.
Create a Jira ticket with technical debt to move this URL to an environment variable and add the ticket in this comment.
There was a problem hiding this comment.
Makes sense. This will be required shortly:
https://poap-devs.atlassian.net/browse/PLT-218
| @@ -6,7 +6,7 @@ const jsonFetch = (url) => fetch(url).then((res) => res.json()); | |||
| * @notice GET list of all POAP events from the POAP API | |||
| */ | |||
| export async function getEvents({ commit }) { | |||
| const events = await jsonFetch('https://api.poap.xyz/events'); | |||
| const events = await jsonFetch('https://api-event.poap.xyz'); | |||
There was a problem hiding this comment.
pablojp
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving our /events request to our S3 bucket that gets updated with the content of /events
Closes issues
Types of Changes
Select at least one of these type of changes.
QA Checklist
I have updated the README (if needed)
I have performed a self-review of my own code
I have added comments (if code has too much complexity)
I have manually tested this code (through Postman or Chrome)
This branch has been rebased from
developmentbefore creating the pull-requestFrontend
Code Reviewer Checklist