Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Feature: Use events from s3 #85

Merged
merged 3 commits into from
May 2, 2022
Merged

✨ Feature: Use events from s3 #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d242d77
Backend - Consume events from s3 bucket
May 2, 2022
ebf4931
Front - Consume events from s3 bucket
May 2, 2022
12a70db
Merge branch 'release/v1.0.1' into feature/PLT-204-fix-vote-to-use-th…
nicolasdeleon May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backend/src/poap/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import axios from 'axios';
class POAP {

static async fetchEvents() {
const response = await axios.get('https://api.poap.tech/events');
const response = await axios.get('https://api-event.poap.xyz');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a Jira ticket with technical debt to move this URL to an environment variable and add the ticket in this comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. This will be required shortly:
https://poap-devs.atlassian.net/browse/PLT-218


return response.data;
}

Expand Down
3 changes: 2 additions & 1 deletion frontend/src/store/poap/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ const jsonFetch = (url) => fetch(url).then((res) => res.json());
* @notice GET list of all POAP events from the POAP API
*/
export async function getEvents({ commit }) {
const events = await jsonFetch('https://api.poap.tech/events');
const events = await jsonFetch('https://api-event.poap.xyz');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, add to technical debt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://poap-devs.atlassian.net/browse/FR-489


commit('setEvents', events);
}

Expand Down