Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.1: Percentage map, list switch feature and NaN error fix #289

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

pengyin-shan
Copy link
Collaborator

@pengyin-shan pengyin-shan commented Jul 15, 2024

This PR covers issues #285, #286, and #290. It includes the following features: adding percentage numbers to the map tips, switching the practice list when users switch between present and predicted data, and fixing the NaN display for some percentage calculations.

How to Test

  1. Navigate to the IRA page and hover over the map. You should see 'PCT. Nationwide' displayed, which should match the Percentage table under the map:
Screenshot 2024-07-18 at 5 20 12 PM
  1. Select a few practices, including some that are not available for predicted years (such as Forest Management Practice Design). You should see a total percentage calculation for all practices appear in the map tips, also matching the Percentage table under the map:
Screenshot 2024-07-18 at 5 23 06 PM
  1. Turn on the '2024-2031 Prediction' switch. You should see any practices that are not available in predicted years (such as Forest Management Practice Design) disappear from the map. The map and tables will update to reflect these changes.

  2. Repeat steps 1 and 2 for the predicted data. No NaN value should appear in any tables or maps.

  3. Turn the '2024-2031 Prediction' switch off and ONLY select practices that are not available in predicted years. Then turn the switch on, and you should see 'Total' being automatically selected in the practice list because all other practices have been removed.

@pengyin-shan pengyin-shan added this to the 1.0.1 milestone Jul 15, 2024
@pengyin-shan pengyin-shan self-assigned this Jul 15, 2024
@pengyin-shan pengyin-shan changed the title [WIP] Percentage map and list switch feature Release 1.0.1: Percentage map, list switch feature and NaN error fix Jul 18, 2024
@pengyin-shan pengyin-shan marked this pull request as ready for review July 18, 2024 22:29
Copy link
Member

@sandeep-ps sandeep-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the percentages for predicted data with Total practice category and also selecting a few other practice categories. The total is adding up to 100%. Approving.

One quick feedback about the PR structure. Since this is not a release PR (develop -> main), it will be better if we don't use "release" and version number in the PR title. These are usually used in the release PRs. Thanks.

Copy link
Contributor

@navarroc navarroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Checked the percent adding correctly for the predicted. Also added a few random practices and verified the percent nationwide for those practices add to 100%.

@pengyin-shan pengyin-shan merged commit 4f5270b into develop Jul 19, 2024
3 checks passed
@pengyin-shan pengyin-shan deleted the issue_286_switch_practices branch July 19, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants