Fix small chunk finaliser bug #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit there was a bug which prevented the finaliser from running for the first slot of a small `chunk` in an actors `heap`. This would result in incorrect behavior but only on a subset of all objects created depending on which slot in a small chunk the object happened to occupy. This commit fixes this issue and also adds a test to catch the issue to prevent regression.
|
Sweet |
Praetonus
approved these changes
Oct 4, 2017
|
Thanks a million @dipinhora ! |
Closed
dipinhora
added a commit
to dipinhora/ponyc
that referenced
this pull request
Oct 9, 2017
dipinhora
added a commit
to dipinhora/ponyc
that referenced
this pull request
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit there was a bug which prevented the finaliser
from running for the first slot of a small
chunkin an actorsheap. This would result in incorrect behavior but only on a subsetof all objects created depending on which slot in a small chunk the
object happened to occupy.
This commit fixes this issue and also adds a test to catch the
issue to prevent regression.
This bugfix is the last remaining hurdle preventing completion of WallarooLabs/wally/issues/1605