Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix File.valid() and clarify File behavior in error cases #2656

Merged
merged 8 commits into from
May 2, 2018
Merged

Fix File.valid() and clarify File behavior in error cases #2656

merged 8 commits into from
May 2, 2018

Commits on Apr 16, 2018

  1. Fix File.valid() and clarify File behavior in error cases 

    mostly by writing tests for these cases
    @mfelsche
    mfelsche committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    508cbcb View commit details
    Browse the repository at this point in the history

  2. ensure dir is deletable and deleted after test

    @mfelsche
    mfelsche committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    7bc9204 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2018

  1. try fix chmod errors on circleci

    @mfelsche
    mfelsche committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    ad2bd57 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2018

  1. run ci docker images as non-root user pony 

    and adapt circleci config to run as non-root user
    @mfelsche
    mfelsche committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    7cd51f1 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2018

  1. use adduser on alpine to create pony user in ci docker images

    @mfelsche
    mfelsche committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    d275f71 View commit details
    Browse the repository at this point in the history

  2. update ci dockerfile READMEs 

    Mentioning the circleci cli for running CI jobs locally.
    @mfelsche
    mfelsche committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    2e486c2 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2018

  1. warn if tests relying on filesystem permissions are run as root

    @mfelsche
    mfelsche committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    3eb2684 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2018

  1. add windows exceptions to file permissions for files tests

    @mfelsche
    mfelsche committed Apr 22, 2018
    Configuration menu
    Copy the full SHA
    a43e4ec View commit details
    Browse the repository at this point in the history