Fix File.valid() and clarify File behavior in error cases #2656
Conversation
mostly by writing tests for these cases
mfelsche
added
the
changelog - fixed
|
The tests fail due to: 1.) It seems file modes do not apply for circle ci mounted volumes |
|
The actual issue seems to be having the tests being run as |
|
Do other tests rely on being root? If not, I don't mind. |
|
If we do that, we should probably also find a way to issue a warning when someone tries to run the tests as |
and adapt circleci config to run as non-root user
Mentioning the circleci cli for running CI jobs locally.
|
According to the windows I will adapt the tests for windows accordingly (and add some comments about the file readability on windows). |
|
@mfelsche is this good to merge now? it looks good to us. if you worked out the root issues, then we all think you should hit the big green button that does the merging. |
|
Thanks for the heads up. The root issues are running stuff as root on linux, which ignores filesystem permissions (fixed) and windows filesystem weirdness (acounted for). Merging... |
) * Fix File.valid() and clarify File behavior in error cases mostly by writing tests for these cases * ensure dir is deletable and deleted after test * try fix chmod errors on circleci * run ci docker images as non-root user pony and adapt circleci config to run as non-root user * use adduser on alpine to create pony user in ci docker images * update ci dockerfile READMEs Mentioning the circleci cli for running CI jobs locally. * warn if tests relying on filesystem permissions are run as root * add windows exceptions to file permissions for files tests
mostly by writing tests for these cases.
TL;DR the behavior is as expected in error cases.
fixes #2570