Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile error with GCC 8.3 #3618

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Fix compile error with GCC 8.3 #3618

merged 2 commits into from
Aug 21, 2020

Conversation

damon-kwok
Copy link
Contributor

@damon-kwok damon-kwok commented Aug 21, 2020 •
edited
Loading

See:

[damon@localhost ponyc-git]$ make build
gmake[1]: Entering directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[2]: Entering directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[3]: Entering directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[3]: Leaving directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[3]: Entering directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
[ 21%] Built target libponyrt
Scanning dependencies of target libponyc
gmake[3]: Entering directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[3]: Leaving directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
[ 26%] Built target libponyrt.tests
gmake[3]: Leaving directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[3]: Entering directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[3]: Leaving directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
[ 29%] Built target libponyrt.benchmarks
gmake[3]: Entering directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
[ 30%] Building C object src/libponyc/CMakeFiles/libponyc.dir/type/cap.c.o
/home/damon/.ome_local/repo/ponyc-git/src/libponyc/type/cap.c: In function ‘cap_safetomove’:
/home/damon/.ome_local/repo/ponyc-git/src/libponyc/type/cap.c:944:11: error: this statement may fall through [-Werror=implicit-fallthrough=]
           switch (direction) {
           ^~~~~~
/home/damon/.ome_local/repo/ponyc-git/src/libponyc/type/cap.c:948:9: note: here
         case TK_BOX:
         ^~~~
cc1: all warnings being treated as errors
gmake[3]: *** [src/libponyc/CMakeFiles/libponyc.dir/build.make:1109: src/libponyc/CMakeFiles/libponyc.dir/type/cap.c.o] Error 1
gmake[3]: Leaving directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[2]: *** [CMakeFiles/Makefile2:267: src/libponyc/CMakeFiles/libponyc.dir/all] Error 2
gmake[2]: Leaving directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[1]: *** [Makefile:149: all] Error 2
gmake[1]: Leaving directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
make: *** [Makefile:159: build] Error 2

This PR Fixed it.

[damon@localhost ponyc-git]$ make build
gmake[1]: Entering directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[2]: Entering directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[3]: Entering directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[3]: Leaving directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[3]: Entering directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
[ 21%] Built target libponyrt
gmake[3]: Leaving directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[3]: Entering directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[3]: Leaving directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
[ 26%] Built target libponyrt.tests
gmake[3]: Entering directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[3]: Leaving directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
[ 70%] Built target libponyc
gmake[3]: Entering directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
[ 73%] Built target libponyrt.benchmarks
gmake[3]: Leaving directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
[ 74%] Built target ponyc
gmake[3]: Entering directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[3]: Entering directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[3]: Leaving directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[3]: Leaving directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
[ 76%] Built target libponyc.benchmarks
[100%] Built target libponyc.tests
gmake[2]: Leaving directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'
gmake[1]: Leaving directory '/home/damon/.ome_local/repo/ponyc-git/build/build_release'

@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Aug 21, 2020
@SeanTAllen SeanTAllen changed the title Fix compile error for gcc8.3(CentOS8.2) Fix compile error for GCC 8.3 Aug 21, 2020
@SeanTAllen SeanTAllen changed the title Fix compile error for GCC 8.3 Fix compile error with GCC 8.3 Aug 21, 2020
@SeanTAllen
Copy link
Member

I made a small formatting change.

@SeanTAllen SeanTAllen merged commit 5eb36de into ponylang:master Aug 21, 2020
github-actions bot pushed a commit that referenced this pull request Aug 21, 2020
@ponylang-main
Update CHANGELOG for PR #3618
b72ba85
@damon-kwok damon-kwok deleted the centos8 branch August 21, 2020 20:22
@felixonmars felixonmars mentioned this pull request Aug 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damon-kwok @SeanTAllen