Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure with latest GCC #3628

Closed
felixonmars opened this issue Aug 29, 2020 · 4 comments
Closed

Build failure with latest GCC #3628

felixonmars opened this issue Aug 29, 2020 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@felixonmars
Copy link
Contributor

This looks different than #3618

[ 52%] Building C object src/libponyc/CMakeFiles/libponyc.dir/expr/reference.c.o
In file included from /build/ponyc/src/ponyc-0.37.0/src/libponyc/expr/reference.c:18:
/build/ponyc/src/ponyc-0.37.0/src/libponyc/expr/reference.c: In function ‘expr_contained_in_recover’:
/build/ponyc/src/ponyc-0.37.0/src/libponyc/../common/ponyassert.h:16:23: error: this statement may fall through [-Werror=implicit-fallthrough=]
   16 |     ((expr) ? (void)0 : \
      |     ~~~~~~~~~~~~~~~~~~^~~
   17 |       ponyint_assert_fail(#expr, __FILE__, __LINE__, __func__))
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/build/ponyc/src/ponyc-0.37.0/src/libponyc/expr/reference.c:222:9: note: in expansion of macro ‘pony_assert’
  222 |         pony_assert(0);
      |         ^~~~~~~~~~~
/build/ponyc/src/ponyc-0.37.0/src/libponyc/expr/reference.c:224:7: note: here
  224 |       case TK_THIS:
      |       ^~~~
@SeanTAllen
Copy link
Member

Can you provide the exact version of gcc you are using?

@felixonmars
Copy link
Contributor Author

Can you provide the exact version of gcc you are using?

I am using GCC 10.2.0.

@SeanTAllen
Copy link
Member

Thanks. Do you feel comfortable enough with C to tackle this and open a PR? If yes, it would be the quickest way to get the issue fixed.

@SeanTAllen SeanTAllen added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Aug 29, 2020
felixonmars added a commit to felixonmars/ponyc that referenced this issue Aug 29, 2020
@felixonmars
Copy link
Contributor Author

@SeanTAllen Sure, opened as #3630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants