Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure under GCC 10.2 #3630

Merged
merged 1 commit into from
Aug 29, 2020
Merged

Conversation

felixonmars
Copy link
Contributor

No description provided.

@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Aug 29, 2020
@SeanTAllen SeanTAllen changed the title Fix build failure under GCC 10.2 (fixes #3628) Fix build failure under GCC 10.2 Aug 29, 2020
@SeanTAllen SeanTAllen added changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge and removed changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge labels Aug 29, 2020
@damon-kwok
Copy link
Contributor

damon-kwok commented Aug 29, 2020

The same error also occurs in GCC8.3. This PR can indeed solve the problem.

[ 31%] Linking CXX executable ../../../release/libponyrt.tests
[ 31%] Building C object src/libponyc/CMakeFiles/libponyc.dir/expr/reference.c.o
In file included from /home/damon/.ome_local/repo/ponyc-git/src/libponyc/expr/reference.c:18:
/home/damon/.ome_local/repo/ponyc-git/src/libponyc/expr/reference.c: In function ‘expr_contained_in_recover’:
/home/damon/.ome_local/repo/ponyc-git/src/libponyc/../common/ponyassert.h:16:23: error: this statement may fall through [-Werror=implicit-fallthrough=]
     ((expr) ? (void)0 : \
     ~~~~~~~~~~~~~~~~~~^~~
       ponyint_assert_fail(#expr, __FILE__, __LINE__, __func__))
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/damon/.ome_local/repo/ponyc-git/src/libponyc/expr/reference.c:222:9: note: in expansion of macro ‘pony_assert’
         pony_assert(0);
         ^~~~~~~~~~~
/home/damon/.ome_local/repo/ponyc-git/src/libponyc/expr/reference.c:224:7: note: here
       case TK_THIS:
       ^~~~
gmake[3]: warning:  Clock skew detected.  Your build may be incomplete.

@SeanTAllen SeanTAllen merged commit 77bcfcb into ponylang:master Aug 29, 2020
@SeanTAllen
Copy link
Member

Thanks @felixonmars

github-actions bot pushed a commit that referenced this pull request Aug 29, 2020
@felixonmars felixonmars deleted the patch-1 branch July 15, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants