-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Talos image #152
Talos image #152
Conversation
A counterpart PR here should be deactivating the docker CI workflow in AIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preferably a reorder of the file in a different PR, but otherwise looks good.
Is linting super inconsistent, surprised how many errors here: https://github.com/populationgenomics/images/actions/runs/9657677094/job/26637372741
images/talos/Dockerfile
Outdated
RUN git clone https://github.com/populationgenomics/automated-interpretation-pipeline.git | ||
|
||
WORKDIR automated-interpretation-pipeline | ||
RUN python3 -m pip install .[cpg] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pip install straight from the github repo, and add a --no-cache-dir
arg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't comfortable doing this before, as I'm using the path to specific scripts for the various steps of the process. I've added an entrypoint to each part of the process in a separate PR so this is doable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair fair, otherwise you'd want to checkout with --depth 1
to avoid git downloading and storing the history
Add a Talos build file to the CPG central images repo - this will mean it is automatically part of the standard analysis-runner config