Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workload identity federated login #553

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Conversation

illusional
Copy link
Collaborator

No description provided.

@illusional illusional requested review from jmarshall and removed request for jmarshall September 19, 2023 03:34
@illusional illusional marked this pull request as ready for review September 19, 2023 04:03
Copy link
Contributor

@jmarshall jmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, in that I'm satisfied that the relevant parts are equivalent to the already-working example in cpg-infrastructure-private.

I'm not qualified to vet the random number in the workload_identity_provider, and it's a bit curious that the tails of the two differ (…/github-pool/providers/github-provider versus …/gh-deploy-pool/providers/gh-provider).

@illusional
Copy link
Collaborator Author

Thanks @jmarshall, that's due to my being inconsistent (but close) in my naming when following the setup example here: https://github.com/google-github-actions/auth

@illusional illusional merged commit 151f61f into dev Sep 20, 2023
2 checks passed
@illusional illusional deleted the workload-identity-federation branch September 20, 2023 00:42
@jmarshall
Copy link
Contributor

Thanks. Basically this is one of the things about GCP that is utterly opaque to those of us who are not intimately working with it at an admin-ish level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants